Fuzz the indexer CLI and fix circular identifier/dialect URIs crash

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

🤖 Augment PR Summary

Summary: This PR hardens the schema resolver against circular metaschema resolution and significantly expands the negative/"fuzz" test coverage for the one index CLI.

Changes:

• Added a re-entrancy/cycle guard in Resolver::operator() to prevent infinite recursion when metaschema chains are circular.
• Implemented per-thread tracking of “currently resolving” schema identifiers and early-return of nullopt on cycles.
• Renamed many index CLI failure tests to a consistent fail-* naming scheme and updated test/cli/CMakeLists.txt accordingly.
• Added new CLI failure tests for circular configuration extends/include scenarios and include-chain cycles.
• Added new failure tests for invalid configuration JSON, invalid schema JSON/YAML, and non-schema inputs (arrays/booleans/empty objects).
• Added coverage for schema dialect/id type errors, unknown dialects, and metaschema self/cycle scenarios.
• Added option parsing/validation failure tests (missing values, non-numeric numeric options, invalid limits).

Technical Notes: Many new tests stabilize output via --concurrency 1 and thread-info stripping to make stderr comparisons deterministic.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[cubic-dev-ai]

No issues found across 51 files

[github-actions]

Benchmark Index (community)

Details

Benchmark suite	Current: c74f43a	Previous: dba66cf	Ratio
Add one schema (0 existing)	21 ms	22 ms	0.95
Add one schema (100 existing)	26 ms	27 ms	0.96
Add one schema (1000 existing)	79 ms	77 ms	1.03
Add one schema (10000 existing)	672 ms	650 ms	1.03
Update one schema (1 existing)	19 ms	19 ms	1
Update one schema (101 existing)	26 ms	27 ms	0.96
Update one schema (1001 existing)	79 ms	79 ms	1
Update one schema (10001 existing)	669 ms	644 ms	1.04
Cached rebuild (1 existing)	11 ms	11 ms	1
Cached rebuild (101 existing)	12 ms	12 ms	1
Cached rebuild (1001 existing)	29 ms	28 ms	1.04
Cached rebuild (10001 existing)	206 ms	199 ms	1.04
Index 100 schemas	153 ms	120 ms	1.27
Index 1000 schemas	1148 ms	999 ms	1.15
Index 10000 schemas	13711 ms	13794 ms	0.99

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark Index (enterprise)

Details

Benchmark suite	Current: c74f43a	Previous: dba66cf	Ratio
Add one schema (0 existing)	23 ms	21 ms	1.10
Add one schema (100 existing)	26 ms	25 ms	1.04
Add one schema (1000 existing)	76 ms	67 ms	1.13
Add one schema (10000 existing)	649 ms	540 ms	1.20
Update one schema (1 existing)	21 ms	20 ms	1.05
Update one schema (101 existing)	26 ms	25 ms	1.04
Update one schema (1001 existing)	80 ms	69 ms	1.16
Update one schema (10001 existing)	609 ms	681 ms	0.89
Cached rebuild (1 existing)	11 ms	11 ms	1
Cached rebuild (101 existing)	13 ms	12 ms	1.08
Cached rebuild (1001 existing)	29 ms	26 ms	1.12
Cached rebuild (10001 existing)	198 ms	178 ms	1.11
Index 100 schemas	120 ms	118 ms	1.02
Index 1000 schemas	1101 ms	982 ms	1.12
Index 10000 schemas	14639 ms	13247 ms	1.11

This comment was automatically generated by workflow using github-action-benchmark.