Handle SchemaVocabularyError with file paths during indexing#791
Handle SchemaVocabularyError with file paths during indexing#791
SchemaVocabularyError with file paths during indexing#791Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: Improves indexing error reporting by attaching schema file paths to 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| std::cerr << "error: " << error.what() << "\n"; | ||
| return EXIT_FAILURE; | ||
| } catch ( | ||
| const sourcemeta::core::FileError<sourcemeta::core::SchemaVocabularyError> |
There was a problem hiding this comment.
main() only handles FileError<SchemaVocabularyError> here; if a plain SchemaVocabularyError escapes without an entry (e.g., execute_plan() rethrows when action.data is empty), it will fall through to the generic std::exception handler and be reported as an "unexpected error" without the vocabulary URI/path context.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 4a30cdb | Previous: 27a390b | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
20 ms |
19 ms |
1.05 |
Add one schema (100 existing) |
26 ms |
26 ms |
1 |
Add one schema (1000 existing) |
78 ms |
77 ms |
1.01 |
Add one schema (10000 existing) |
676 ms |
660 ms |
1.02 |
Update one schema (1 existing) |
18 ms |
20 ms |
0.90 |
Update one schema (101 existing) |
26 ms |
27 ms |
0.96 |
Update one schema (1001 existing) |
80 ms |
79 ms |
1.01 |
Update one schema (10001 existing) |
687 ms |
667 ms |
1.03 |
Cached rebuild (1 existing) |
10 ms |
10 ms |
1 |
Cached rebuild (101 existing) |
12 ms |
12 ms |
1 |
Cached rebuild (1001 existing) |
34 ms |
33 ms |
1.03 |
Cached rebuild (10001 existing) |
274 ms |
265 ms |
1.03 |
Index 100 schemas |
149 ms |
163 ms |
0.91 |
Index 1000 schemas |
1156 ms |
1166 ms |
0.99 |
Index 10000 schemas |
14288 ms |
14141 ms |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 4a30cdb | Previous: 27a390b | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
23 ms |
24 ms |
0.96 |
Add one schema (100 existing) |
27 ms |
27 ms |
1 |
Add one schema (1000 existing) |
78 ms |
79 ms |
0.99 |
Add one schema (10000 existing) |
636 ms |
648 ms |
0.98 |
Update one schema (1 existing) |
22 ms |
20 ms |
1.10 |
Update one schema (101 existing) |
27 ms |
26 ms |
1.04 |
Update one schema (1001 existing) |
81 ms |
79 ms |
1.03 |
Update one schema (10001 existing) |
658 ms |
652 ms |
1.01 |
Cached rebuild (1 existing) |
12 ms |
11 ms |
1.09 |
Cached rebuild (101 existing) |
14 ms |
13 ms |
1.08 |
Cached rebuild (1001 existing) |
36 ms |
35 ms |
1.03 |
Cached rebuild (10001 existing) |
270 ms |
270 ms |
1 |
Index 100 schemas |
124 ms |
118 ms |
1.05 |
Index 1000 schemas |
1064 ms |
1015 ms |
1.05 |
Index 10000 schemas |
13670 ms |
13204 ms |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com