Skip to content

Fix /self not presented as a special directory given a base path#825

Merged
jviotti merged 2 commits intomainfrom
self-special
Apr 9, 2026
Merged

Fix /self not presented as a special directory given a base path#825
jviotti merged 2 commits intomainfrom
self-special

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 9, 2026

No description provided.

jviotti added 2 commits April 9, 2026 09:40
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti changed the title self special Fix /self not presented as a special directory given a base path Apr 9, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 9, 2026

🤖 Augment PR Summary

Summary: This PR fixes the HTML file manager so the /self directory is still treated as a “special directory” when the instance is served under a non-empty base path.

Changes:

  • Passes configuration.base_path into html::make_file_manager (index + directory pages)
  • Updates special-directory detection to match {base_path}/self (and trailing-slash variant) instead of hard-coding /self
  • Adds E2E coverage (Hurl + Playwright) to assert /self appears only in the “Special directories” table for both root and base-path deployments
  • Cleans up unused includes in the affected page generators

Technical Notes: Relies on the already-normalized base_path (no trailing slash) from configuration parsing to build the expected “self” entry path.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 307e148 Previous: a90a634 Ratio
Add one schema (0 existing) 17 ms 18 ms 0.94
Add one schema (100 existing) 22 ms 23 ms 0.96
Add one schema (1000 existing) 75 ms 74 ms 1.01
Add one schema (10000 existing) 964 ms 657 ms 1.47
Update one schema (1 existing) 16 ms 16 ms 1
Update one schema (101 existing) 22 ms 23 ms 0.96
Update one schema (1001 existing) 77 ms 77 ms 1
Update one schema (10001 existing) 642 ms 665 ms 0.97
Cached rebuild (1 existing) 9 ms 9 ms 1
Cached rebuild (101 existing) 10 ms 10 ms 1
Cached rebuild (1001 existing) 31 ms 30 ms 1.03
Cached rebuild (10001 existing) 247 ms 252 ms 0.98
Index 100 schemas 113 ms 124 ms 0.91
Index 1000 schemas 1046 ms 964 ms 1.09
Index 10000 schemas 13783 ms 13014 ms 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 307e148 Previous: a90a634 Ratio
Add one schema (0 existing) 21 ms 20 ms 1.05
Add one schema (100 existing) 25 ms 25 ms 1
Add one schema (1000 existing) 80 ms 73 ms 1.10
Add one schema (10000 existing) 709 ms 899 ms 0.79
Update one schema (1 existing) 20 ms 19 ms 1.05
Update one schema (101 existing) 25 ms 25 ms 1
Update one schema (1001 existing) 76 ms 74 ms 1.03
Update one schema (10001 existing) 653 ms 657 ms 0.99
Cached rebuild (1 existing) 11 ms 10 ms 1.10
Cached rebuild (101 existing) 12 ms 12 ms 1
Cached rebuild (1001 existing) 32 ms 32 ms 1
Cached rebuild (10001 existing) 260 ms 292 ms 0.89
Index 100 schemas 113 ms 117 ms 0.97
Index 1000 schemas 1087 ms 1129 ms 0.96
Index 10000 schemas 13504 ms 13602 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 93a6b3b into main Apr 9, 2026
6 checks passed
@jviotti jviotti deleted the self-special branch April 9, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant