Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 107 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritises the most important files to review.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/self/v1/schemas/mcp/resources/list/response.json">
<violation number="1" location="src/self/v1/schemas/mcp/resources/list/response.json:28">
P2: The schema fixes `resources` to an empty array, so any non-empty resources list will fail validation. Define it as an array instead of a constant empty list.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 7d06757 | Previous: 02ef2bf | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
208 ms |
163 ms |
1.28 |
Add one schema (100 existing) |
22 ms |
22 ms |
1 |
Add one schema (1000 existing) |
73 ms |
79 ms |
0.92 |
Add one schema (10000 existing) |
987 ms |
1012 ms |
0.98 |
Update one schema (1 existing) |
16 ms |
15 ms |
1.07 |
Update one schema (101 existing) |
24 ms |
22 ms |
1.09 |
Update one schema (1001 existing) |
79 ms |
79 ms |
1 |
Update one schema (10001 existing) |
689 ms |
690 ms |
1.00 |
Cached rebuild (1 existing) |
4 ms |
4 ms |
1 |
Cached rebuild (101 existing) |
7 ms |
7 ms |
1 |
Cached rebuild (1001 existing) |
27 ms |
29 ms |
0.93 |
Cached rebuild (10001 existing) |
248 ms |
327 ms |
0.76 |
Index 100 schemas |
127 ms |
131 ms |
0.97 |
Index 1000 schemas |
974 ms |
1108 ms |
0.88 |
Index 10000 schemas |
13571 ms |
13004 ms |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 7d06757 | Previous: 02ef2bf | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
217 ms |
158 ms |
1.37 |
Add one schema (100 existing) |
25 ms |
22 ms |
1.14 |
Add one schema (1000 existing) |
76 ms |
70 ms |
1.09 |
Add one schema (10000 existing) |
650 ms |
576 ms |
1.13 |
Update one schema (1 existing) |
18 ms |
15 ms |
1.20 |
Update one schema (101 existing) |
24 ms |
21 ms |
1.14 |
Update one schema (1001 existing) |
78 ms |
70 ms |
1.11 |
Update one schema (10001 existing) |
660 ms |
602 ms |
1.10 |
Cached rebuild (1 existing) |
6 ms |
5 ms |
1.20 |
Cached rebuild (101 existing) |
8 ms |
7 ms |
1.14 |
Cached rebuild (1001 existing) |
31 ms |
27 ms |
1.15 |
Cached rebuild (10001 existing) |
273 ms |
242 ms |
1.13 |
Index 100 schemas |
123 ms |
106 ms |
1.16 |
Index 1000 schemas |
1115 ms |
1029 ms |
1.08 |
Index 10000 schemas |
13582 ms |
12981 ms |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com