Make GENERATE_MCP depend on routes.bin at the delta level#910
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 40 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 507f38f | Previous: 219a686 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
233 ms |
238 ms |
0.98 |
Add one schema (100 existing) |
28 ms |
27 ms |
1.04 |
Add one schema (1000 existing) |
86 ms |
85 ms |
1.01 |
Add one schema (10000 existing) |
768 ms |
906 ms |
0.85 |
Update one schema (1 existing) |
20 ms |
20 ms |
1 |
Update one schema (101 existing) |
29 ms |
27 ms |
1.07 |
Update one schema (1001 existing) |
88 ms |
85 ms |
1.04 |
Update one schema (10001 existing) |
723 ms |
707 ms |
1.02 |
Cached rebuild (1 existing) |
7 ms |
7 ms |
1 |
Cached rebuild (101 existing) |
9 ms |
9 ms |
1 |
Cached rebuild (1001 existing) |
32 ms |
32 ms |
1 |
Cached rebuild (10001 existing) |
278 ms |
277 ms |
1.00 |
Index 100 schemas |
113 ms |
113 ms |
1 |
Index 1000 schemas |
1120 ms |
1129 ms |
0.99 |
Index 10000 schemas |
14771 ms |
13918 ms |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 507f38f | Previous: 219a686 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
205 ms |
245 ms |
0.84 |
Add one schema (100 existing) |
19 ms |
24 ms |
0.79 |
Add one schema (1000 existing) |
63 ms |
81 ms |
0.78 |
Add one schema (10000 existing) |
741 ms |
661 ms |
1.12 |
Update one schema (1 existing) |
14 ms |
20 ms |
0.70 |
Update one schema (101 existing) |
19 ms |
26 ms |
0.73 |
Update one schema (1001 existing) |
64 ms |
81 ms |
0.79 |
Update one schema (10001 existing) |
578 ms |
671 ms |
0.86 |
Cached rebuild (1 existing) |
3 ms |
5 ms |
0.60 |
Cached rebuild (101 existing) |
4 ms |
7 ms |
0.57 |
Cached rebuild (1001 existing) |
18 ms |
28 ms |
0.64 |
Cached rebuild (10001 existing) |
161 ms |
245 ms |
0.66 |
Index 100 schemas |
87 ms |
114 ms |
0.76 |
Index 1000 schemas |
681 ms |
906 ms |
0.75 |
Index 10000 schemas |
11105 ms |
13399 ms |
0.83 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com