Skip to content

Upgrade Core to 178137768156f9c8672dce6ec9d1a95a46ee3eae#940

Merged
jviotti merged 1 commit into
mainfrom
mcp-core
May 24, 2026
Merged

Upgrade Core to 178137768156f9c8672dce6ec9d1a95a46ee3eae#940
jviotti merged 1 commit into
mainfrom
mcp-core

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 24, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 41 files

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 24, 2026

🤖 Augment PR Summary

Summary: This PR upgrades the vendored sourcemeta/core dependency to 178137768156f9c8672dce6ec9d1a95a46ee3eae and migrates MCP (Model Context Protocol) helpers out of one into core.

Changes:

  • Stop building/linking sourcemeta::one::mcp and switch consumers to sourcemeta::core::mcp (enterprise + index/server/actions/router).
  • Remove the src/mcp implementation and the test/unit/mcp unit tests from this repo.
  • Add a new vendored core MCP component (vendor/core/src/core/mcp) with a build option SOURCEMETA_CORE_MCP.
  • Update several call sites to use sourcemeta::core::MCPProtocolVersion and sourcemeta::core::MCP_METHOD_* constants.
  • Core JSON/JSON-RPC internals were adjusted (static object key hashing; jsonrpc_method now returns JSON::StringView).

Technical Notes: The MCP request/response envelope construction now comes from core; RouterAction::mcp’s signature is updated accordingly, so downstream implementations must use the core MCP types.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread CMakeLists.txt
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: a0db67a Previous: 0d3da41 Ratio
Add one schema (0 existing) 295 ms 225 ms 1.31
Add one schema (100 existing) 27 ms 21 ms 1.29
Add one schema (1000 existing) 82 ms 90 ms 0.91
Add one schema (10000 existing) 696 ms 871 ms 0.80
Update one schema (1 existing) 18 ms 15 ms 1.20
Update one schema (101 existing) 26 ms 22 ms 1.18
Update one schema (1001 existing) 80 ms 85 ms 0.94
Update one schema (10001 existing) 908 ms 896 ms 1.01
Cached rebuild (1 existing) 5 ms 4 ms 1.25
Cached rebuild (101 existing) 7 ms 6 ms 1.17
Cached rebuild (1001 existing) 28 ms 25 ms 1.12
Cached rebuild (10001 existing) 273 ms 221 ms 1.24
Index 100 schemas 115 ms 97 ms 1.19
Index 1000 schemas 912 ms 821 ms 1.11
Index 10000 schemas 12812 ms 15273 ms 0.84

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: a0db67a Previous: 0d3da41 Ratio
Add one schema (0 existing) 287 ms 293 ms 0.98
Add one schema (100 existing) 30 ms 30 ms 1
Add one schema (1000 existing) 86 ms 88 ms 0.98
Add one schema (10000 existing) 697 ms 746 ms 0.93
Update one schema (1 existing) 21 ms 23 ms 0.91
Update one schema (101 existing) 29 ms 30 ms 0.97
Update one schema (1001 existing) 88 ms 90 ms 0.98
Update one schema (10001 existing) 699 ms 705 ms 0.99
Cached rebuild (1 existing) 7 ms 7 ms 1
Cached rebuild (101 existing) 9 ms 10 ms 0.90
Cached rebuild (1001 existing) 32 ms 33 ms 0.97
Cached rebuild (10001 existing) 275 ms 284 ms 0.97
Index 100 schemas 121 ms 120 ms 1.01
Index 1000 schemas 1134 ms 1075 ms 1.05
Index 10000 schemas 13655 ms 13804 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit f7833b2 into main May 24, 2026
5 checks passed
@jviotti jviotti deleted the mcp-core branch May 24, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant