Skip to content

Update evaluate/trace MCP tools to take a stringified instance#945

Merged
jviotti merged 3 commits into
mainfrom
mcp-stringified-instance
May 25, 2026
Merged

Update evaluate/trace MCP tools to take a stringified instance#945
jviotti merged 3 commits into
mainfrom
mcp-stringified-instance

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 25, 2026

No description provided.

jviotti added 2 commits May 25, 2026 12:55
Given MCP client common limitations.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 25, 2026

🤖 Augment PR Summary

Summary: Updates the MCP (2025-11-25) JSON Schema evaluate/trace tools to accept the instance as a JSON-encoded string and parse it server-side.

Changes:

  • Rename tool argument from instance to stringifiedInstance across MCP e2e suites.
  • Parse stringifiedInstance in ActionJSONSchemaEvaluate_v1 before validation.
  • Parse stringifiedInstance with a PointerPositionTracker in ActionJSONSchemaTrace_v1, so instancePositions refer to the parsed instance content.
  • Return an MCP tool error (not JSON-RPC invalid params) when the provided string is not valid JSON.

Technical Notes:

  • RPC input schemas are updated to require stringifiedInstance and document the client-stringification workaround.
  • E2E assertions are updated for new argument names, new schema sizes, and updated instancePositions offsets.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti changed the title mcp stringified instance Update evaluate/trace MCP tools to take a stringified instance May 25, 2026
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 323123e Previous: 96ce22d Ratio
Add one schema (0 existing) 282 ms 292 ms 0.97
Add one schema (100 existing) 24 ms 26 ms 0.92
Add one schema (1000 existing) 77 ms 80 ms 0.96
Add one schema (10000 existing) 645 ms 886 ms 0.73
Update one schema (1 existing) 17 ms 19 ms 0.89
Update one schema (101 existing) 24 ms 27 ms 0.89
Update one schema (1001 existing) 76 ms 83 ms 0.92
Update one schema (10001 existing) 656 ms 683 ms 0.96
Cached rebuild (1 existing) 5 ms 5 ms 1
Cached rebuild (101 existing) 7 ms 8 ms 0.88
Cached rebuild (1001 existing) 27 ms 28 ms 0.96
Cached rebuild (10001 existing) 239 ms 248 ms 0.96
Index 100 schemas 111 ms 118 ms 0.94
Index 1000 schemas 896 ms 930 ms 0.96
Index 10000 schemas 13044 ms 13830 ms 0.94

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 323123e Previous: 96ce22d Ratio
Add one schema (0 existing) 284 ms 287 ms 0.99
Add one schema (100 existing) 29 ms 29 ms 1
Add one schema (1000 existing) 86 ms 86 ms 1
Add one schema (10000 existing) 693 ms 694 ms 1.00
Update one schema (1 existing) 21 ms 21 ms 1
Update one schema (101 existing) 28 ms 30 ms 0.93
Update one schema (1001 existing) 87 ms 87 ms 1
Update one schema (10001 existing) 701 ms 700 ms 1.00
Cached rebuild (1 existing) 7 ms 7 ms 1
Cached rebuild (101 existing) 9 ms 9 ms 1
Cached rebuild (1001 existing) 32 ms 32 ms 1
Cached rebuild (10001 existing) 274 ms 275 ms 1.00
Index 100 schemas 120 ms 118 ms 1.02
Index 1000 schemas 1044 ms 1164 ms 0.90
Index 10000 schemas 13592 ms 14388 ms 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit c35fa5c into main May 25, 2026
5 checks passed
@jviotti jviotti deleted the mcp-stringified-instance branch May 25, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant