Group all protocol related types into protocol/

protocol/cli.d.ts

@@ -0,0 +1,54 @@
+/**
+ * CLI-related types
+ * Types that represent CLI command results and errors
+ */
+
+export interface LintError {
+  id: string;
+  message: string;
+  description?: string | null;
+  path: string;
+  schemaLocation: string;
+  position: [number, number, number, number] | null;
+}
+
+export interface LintResult {
+  raw: string;
+  health: number | null;
+  valid?: boolean;
+  errors?: LintError[];
+  error?: boolean;
+}
+
+export interface CommandResult {
+  output: string;
+  exitCode: number | null;
+}
+
+export interface MetaschemaError {
+  error: string;
+  instanceLocation: string;
+  keywordLocation: string;
+  absoluteKeywordLocation?: string;
+  instancePosition?: [number, number, number, number];
+}
+
+export interface CliError {
+  error: string;
+  line?: number;
+  column?: number;
+  filePath?: string;
+  identifier?: string;
+  location?: string;
+  rule?: string;
+  testNumber?: number;
+  uri?: string;
+  command?: string;
+  option?: string;
+}
+
+export interface MetaschemaResult extends CommandResult {
+  errors?: (MetaschemaError | CliError)[];
+}
+
+export type FormatResult = CommandResult;

protocol/types.d.ts

@@ -0,0 +1,61 @@
+/**
+ * Protocol types for communication between VSCode extension and webview
+ * This file defines the message passing contract
+ */
+
+import type {
+  LintResult,
+  FormatResult,
+  MetaschemaResult
+} from './cli';
+
+export type TabType = 'lint' | 'format' | 'metaschema';
+
+export interface WebviewState {
+  activeTab?: TabType;
+}
+
+export interface FileInfo {
+  absolutePath: string;
+  displayPath: string;
+  fileName: string;
+  lineCount?: number;
+  isYaml?: boolean;
+}
+
+export type {
+  LintError,
+  LintResult,
+  CommandResult,
+  MetaschemaError,
+  CliError,
+  MetaschemaResult,
+  FormatResult
+} from './cli';
+
+export interface PanelState {
+  fileInfo: FileInfo | null;
+  cliVersion: string;
+  extensionVersion: string;
+  lintResult: LintResult;
+  formatResult: FormatResult;
+  metaschemaResult: MetaschemaResult;
+  isLoading?: boolean;
+  formatLoading?: boolean;
+  hasParseErrors?: boolean;
+  blockedByMetaschema?: boolean;
+  noFileSelected?: boolean;
+}
+
+export type WebviewCommand = 'goToPosition' | 'formatSchema' | 'openExternal';
+
+export interface WebviewToExtensionMessage {
+  command: WebviewCommand;
+  position?: [number, number, number, number];
+  url?: string;
+}
+
+export interface ExtensionToWebviewMessage {
+  type: 'update';
+  state: PanelState;
+}

vscode/src/commands/CommandExecutor.ts

@@ -1,5 +1,5 @@
 import { spawn } from 'child_process';
-import { CommandResult } from '../../../shared/types';
+import { CommandResult } from '../../../protocol/types';
 
 /**
  * Execute a CLI command and return the result

vscode/src/diagnostics/DiagnosticManager.ts

@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
 import { DiagnosticType } from '../types';
-import { LintError, CliError, MetaschemaError } from '../../../shared/types';
+import { LintError, CliError, MetaschemaError } from '../../../protocol/types';
 import { errorPositionToRange } from '../utils/fileUtils';
 
 /**

vscode/src/extension.ts

@@ -5,7 +5,7 @@ import { PanelManager } from './panel/PanelManager';
 import { CommandExecutor } from './commands/CommandExecutor';
 import { DiagnosticManager } from './diagnostics/DiagnosticManager';
 import { getFileInfo, parseLintResult, parseMetaschemaResult, errorPositionToRange, parseCliError, hasJsonParseErrors } from './utils/fileUtils';
-import { WebviewMessage, PanelState } from '../../shared/types';
+import { PanelState, WebviewToExtensionMessage } from '../../protocol/types';
 import { DiagnosticType } from './types';
 
 let panelManager: PanelManager;
@@ -42,7 +42,7 @@ export function activate(context: vscode.ExtensionContext): void {
         context.subscriptions.push(collection);
     });
 
-    panelManager.setMessageHandler((message: WebviewMessage) => {
+    panelManager.setMessageHandler((message: WebviewToExtensionMessage) => {
         handleWebviewMessage(message);
     });
 
@@ -73,7 +73,7 @@ export function activate(context: vscode.ExtensionContext): void {
 /**
  * Handle messages from the webview
  */
-function handleWebviewMessage(message: WebviewMessage): void {
+function handleWebviewMessage(message: WebviewToExtensionMessage): void {
     if (message.command === 'goToPosition' && lastActiveTextEditor && message.position) {
         const range = errorPositionToRange(message.position);
 

vscode/src/panel/PanelManager.ts

@@ -1,7 +1,7 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
 import * as fs from 'fs';
-import { WebviewMessage, PanelState } from '../../../shared/types';
+import { PanelState, WebviewToExtensionMessage, ExtensionToWebviewMessage } from '../../../protocol/types';
 
 /**
  * Manages the webview panel lifecycle and content
@@ -10,7 +10,7 @@ export class PanelManager {
     private panel: vscode.WebviewPanel | undefined;
     private readonly iconPath: vscode.Uri;
     private readonly extensionPath: string;
-    private messageHandler?: (message: WebviewMessage) => void;
+    private messageHandler?: (message: WebviewToExtensionMessage) => void;
 
     constructor(extensionPath: string) {
         this.extensionPath = extensionPath;
@@ -20,7 +20,7 @@ export class PanelManager {
     /**
      * Set the message handler for webview messages
      */
-    setMessageHandler(handler: (message: WebviewMessage) => void): void {
+    setMessageHandler(handler: (message: WebviewToExtensionMessage) => void): void {
         this.messageHandler = handler;
     }
 
@@ -90,11 +90,11 @@ export class PanelManager {
             return;
         }
 
-        // Send state update to React webview
-        this.panel.webview.postMessage({
+        const message: ExtensionToWebviewMessage = {
             type: 'update',
             state: state
-        });
+        };
+        this.panel.webview.postMessage(message);
     }
 
     /**

vscode/src/utils/fileUtils.ts

@@ -1,7 +1,7 @@
 import * as path from 'path';
 import * as vscode from 'vscode';
 import * as fs from 'fs';
-import { FileInfo, LintResult, MetaschemaResult, CliError } from '../../../shared/types';
+import { FileInfo, LintResult, MetaschemaResult, CliError } from '../../../protocol/types';
 
 /**
  * Parse generic CLI error response from JSON output

webview/src/App.tsx

@@ -1,5 +1,5 @@
 import { useState, useEffect } from 'react';
-import type { PanelState } from '../../shared/types.ts';
+import type { PanelState } from '../../protocol/types';
 import { vscode, type TabType } from './vscode-api';
 import { FileInfo } from './components/FileInfo';
 import { HealthBar } from './components/HealthBar';

webview/src/components/FileInfo.tsx

@@ -1,4 +1,4 @@
-import type { FileInfo as FileInfoType } from '../../../shared/types.ts';
+import type { FileInfo as FileInfoType } from '../../../protocol/types';
 
 export interface FileInfoProps {
   fileInfo: FileInfoType | null;

webview/src/components/FormatTab.tsx

@@ -1,4 +1,4 @@
-import type { CommandResult, FileInfo } from '../../../shared/types.ts';
+import type { CommandResult, FileInfo } from '../../../protocol/types';
 import { vscode } from '../vscode-api';
 import { RawOutput } from './RawOutput';
 import { Info, CheckCircle, AlertCircle, FileQuestion } from 'lucide-react';

webview/src/components/HealthBar.tsx

@@ -1,4 +1,4 @@
-import type { LintResult } from '../../../shared/types.ts';
+import type { LintResult } from '../../../protocol/types';
 
 export interface HealthBarProps {
   lintResult: LintResult;

webview/src/components/LintTab.tsx

@@ -1,4 +1,4 @@
-import type { LintResult } from '../../../shared/types.ts';
+import type { LintResult } from '../../../protocol/types';
 import { vscode } from '../vscode-api';
 import { RawOutput } from './RawOutput';
 import { CheckCircle, AlertCircle, FileQuestion } from 'lucide-react';

webview/src/components/LoadingSpinner.tsx

@@ -1,4 +1,4 @@
-import type { FileInfo } from '../../../shared/types.ts';
+import type { FileInfo } from '../../../protocol/types';
 import { AlertTriangle } from 'lucide-react';
 
 export interface LoadingSpinnerProps {

webview/src/components/MetaschemaTab.tsx

@@ -1,4 +1,4 @@
-import type { MetaschemaResult, MetaschemaError } from '../../../shared/types.ts';
+import type { MetaschemaResult, MetaschemaError } from '../../../protocol/types';
 import { vscode } from '../vscode-api';
 import { RawOutput } from './RawOutput';
 import { CheckCircle, AlertTriangle, FileQuestion } from 'lucide-react';

webview/src/components/Tabs.tsx

@@ -1,4 +1,4 @@
-import type { PanelState } from '../../../shared/types.ts';
+import type { PanelState } from '../../../protocol/types';
 import type { LucideIcon } from 'lucide-react';
 import { calculateLintStatus, calculateFormatStatus, calculateMetaschemaStatus } from '../utils/tabStatus';
 

webview/src/vscode-api.ts

@@ -1,4 +1,6 @@
-export type TabType = 'lint' | 'format' | 'metaschema';
+import type { TabType, WebviewState, WebviewToExtensionMessage } from '../../protocol/types';
+
+export type { TabType };
 
 interface VSCodeAPI {
   postMessage(message: unknown): void;
@@ -15,7 +17,7 @@ declare global {
 class VSCodeAPIWrapper {
   private readonly vsCodeApi = window.acquireVsCodeApi();
 
-  private postMessage(message: unknown): void {
+  private postMessage(message: WebviewToExtensionMessage): void {
     this.vsCodeApi.postMessage(message);
   }
 
@@ -32,12 +34,12 @@ class VSCodeAPIWrapper {
   }
 
   public getActiveTab(): TabType | undefined {
-    const state = this.vsCodeApi.getState() as { activeTab?: TabType } | undefined;
+    const state = this.vsCodeApi.getState() as WebviewState | undefined;
     return state?.activeTab;
   }
 
   public setActiveTab(tab: TabType): void {
-    this.vsCodeApi.setState({ activeTab: tab });
+    this.vsCodeApi.setState({ activeTab: tab } satisfies WebviewState);
   }
 }