Skip to content

ClassCastException in express endpoint detector #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2022
Merged

ClassCastException in express endpoint detector #862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f93c43
fix: sourceplusplus/sourceplusplus#720
MrMineO5 Oct 4, 2022
1541be4
Merge branch 'master' into master
BFergerson Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions marker/js-marker/src/main/kotlin/spp/jetbrains/marker/js/detect/endpoint/ExpressEndpoint.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ class ExpressEndpoint : EndpointDetector.EndpointNameDeterminer {
return@runReadAction
}
val router = method.firstChild as JSReferenceExpression
val routerVariable = router.resolve() as JSVariable? ?: return@runReadAction
val routerVariable = router.resolve() as JSInitializerOwner? ?: run {
promise.complete(Optional.empty())
return@runReadAction
}

if (method.children.size < 3) {
promise.complete(Optional.empty())
Expand Down Expand Up @@ -97,7 +100,7 @@ class ExpressEndpoint : EndpointDetector.EndpointNameDeterminer {
return promise.future()
}

private fun locateRouter(routerVariable: JSVariable): String? {
private fun locateRouter(routerVariable: JSInitializerOwner): String? {
if (isExpressApp(routerVariable)) {
return ""
}
Expand Down