Merged
Conversation
HusseinKabbout
force-pushed
the
support-secret-vaults
branch
from
13431c6 to
1c6af64
Compare
tpo
requested changes
Oct 27, 2023
Member
tpo
left a comment
tpo
left a comment
There was a problem hiding this comment.
Here you are deleting files that exist upstream.
I'd prefer if we could keep the identical code base as upstream except for our strictly necessary changes.
So would it be possible not to delete files that exist upstream?
HusseinKabbout
force-pushed
the
support-secret-vaults
branch
from
1c6af64 to
4b308b0
Compare
HusseinKabbout
force-pushed
the
support-secret-vaults
branch
2 times, most recently
from
33415b2 to
2746251
Compare
This allows users to specify their own command to retrieve passwords
HusseinKabbout
force-pushed
the
support-secret-vaults
branch
from
2746251 to
39e06fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.