Feature/preceding following signs #2

sourcery-ai-experiments-bot · 2024-04-22T19:41:19Z

Added endpoint to get preceding or following signs for any sign and sort key
E.g., "/signs/BAR/following/NeoAssyrianOffset"

* Added method to mongo_sign_repository for getting preceding signs

sourcery-ai-experiments-bot · 2024-04-22T19:41:24Z

This is a benchmark review for experiment review_of_reviews_20240422_1934.
Run ID: review_of_reviews_20240422_1934/benchmark_2024-04-22T19-34-40_v1-16-0-167-g495a26b3d.

This pull request was cloned from https://github.com/ElectronicBabylonianLiterature/ebl-api/pull/546. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration

review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: benchmark
    enable_docstring_comments: benchmark
    enable_security_comments: benchmark
    enable_tests_comments: benchmark
    enable_comment_suggestions: benchmark

    enable_approvals: true

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      docstrings_model: benchmark
      security_model: benchmark
      tests_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/erxes/erxes/pull/5153
- https://github.com/0ussamaBernou/my-portfolio/pull/6
- https://github.com/strawberry-graphql/strawberry/pull/3467
- https://github.com/shreejitverma/MScFE690-Capstone/pull/6
- https://github.com/gdsfactory/kfactory/pull/298
- https://github.com/2lambda123/kwenta/pull/50
- https://github.com/EduardSchwarzkopf/pecuny/pull/128
- https://github.com/ElectronicBabylonianLiterature/ebl-api/pull/546
- https://github.com/ShiroePL/EasternTalesShelf/pull/44
- https://github.com/kloudlite/web/pull/195
- https://github.com/dciborow/action-pylint/pull/14
- https://github.com/4DNucleome/PartSeg/pull/1099
- https://github.com/nbhirud/nbhirud.github.io/pull/6
- https://github.com/EduardSchwarzkopf/pecuny/pull/129
- https://github.com/Xmaster6y/mulsi/pull/17
- https://github.com/shreejitverma/MScFE690-Capstone/pull/5
- https://github.com/zen-audio-player/zen-audio-player.github.io/pull/431
- https://github.com/Xmaster6y/mulsi/pull/15
- https://github.com/LunaPurpleSunshine/ipget/pull/196
- https://github.com/erxes/erxes/pull/5152
- https://github.com/ShiroePL/EasternTalesShelf/pull/45
- https://github.com/LunaPurpleSunshine/ipget/pull/195
- https://github.com/osama1998H/spms/pull/56
- https://github.com/gdsfactory/gdsfactory/pull/2694
- https://github.com/shreejitverma/MScFE690-Capstone/pull/4
- https://github.com/albumentations-team/albumentations/pull/1679
- https://github.com/osama1998H/spms/pull/57
- https://github.com/CPUT-DEVS/devpost-hackathon/pull/29
- https://github.com/Amm1rr/WebAI-to-API/pull/31
- https://github.com/DevCycleHQ/go-server-sdk/pull/248
- https://github.com/0ussamaBernou/my-portfolio/pull/8
- https://github.com/LunaPurpleSunshine/ipget/pull/194
- https://github.com/jackdewinter/pymarkdown/pull/1061
- https://github.com/osism/python-osism/pull/869
- https://github.com/nbhirud/nbhirud.github.io/pull/5
- https://github.com/CPUT-DEVS/devpost-hackathon/pull/28
- https://github.com/yaitoo/sqle/pull/41
- https://github.com/gdsfactory/kfactory/pull/300
- https://github.com/osama1998H/spms/pull/55
- https://github.com/shreejitverma/MScFE690-Capstone/pull/7
- https://github.com/nbhirud/system_update/pull/18
- https://github.com/jackdewinter/pymarkdown/pull/1060
- https://github.com/strawberry-graphql/strawberry/pull/3469
- https://github.com/Xmaster6y/mulsi/pull/18
- https://github.com/jkool702/openwrt/pull/41
- https://github.com/nbhirud/nbhirud.github.io/pull/4
- https://github.com/NoobInDaHause/NoobCogs/pull/13
- https://github.com/UCL/dxss/pull/63
- https://github.com/nbhirud/nbhirud.github.io/pull/3
- https://github.com/nbhirud/system_update/pull/17
review_comment_labels:
- label: correct
  question: Is this comment correct?
- label: helpful
  question: Is this comment helpful?
- label: comment-type
  question: Is the comment type correct?
- label: comment-area
  question: Is the comment area correct?
- label: llm-test
  question: Should this comment become an LLM test?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews: []

SourceryAI

Hey @sourcery-ai-experiments-bot - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 2 issues found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Docstrings: all looks good

LangSmith trace

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

SourceryAI · 2024-04-22T19:46:49Z

ebl/signs/infrastructure/mongo_sign_repository.py

        data = self._collection.find_one_by_id(name)
        return cast(Sign, SignSchema(unknown=EXCLUDE).load(data))

+    def find_signs_by_order(self, name: SignName, order: str, sort_era: str) -> Sign:


issue (code_clarification): Return type of 'find_signs_by_order' should be List[Sign] instead of Sign.

The method appears to return a list of signs, not a single sign, as indicated by the use of 'many=True' in the schema loading.

Is this comment correct?

Is this comment helpful?

Is the comment type correct?

Is the comment area correct?

Should this comment become an LLM test?

SourceryAI · 2024-04-22T19:46:49Z

ebl/signs/infrastructure/mongo_sign_repository.py

        return cast(Sign, SignSchema(unknown=EXCLUDE).load(data))

+    def find_signs_by_order(self, name: SignName, order: str, sort_era: str) -> Sign:
+        key = self._collection.find_one_by_id(name)["sortKeys"][sort_era][0]


issue (edge_case_not_handled): Potential risk of KeyError if 'sortKeys' or 'sort_era' does not exist.

Consider adding error handling or checks to ensure the keys exist before accessing them to avoid runtime errors.

Is this comment correct?

Is this comment helpful?

Is the comment type correct?

Is the comment area correct?

Should this comment become an LLM test?

Vas9ka added 3 commits April 8, 2024 11:12

* Added endpoint to get preceding signs for specific sign and sortkey

6110a01

* Added method to mongo_sign_repository for getting preceding signs

added endpoint for the following signs

92c1016

typecheck errors fixed

551745f

SourceryAI approved these changes Apr 22, 2024

View reviewed changes

Feature/preceding following signs #2

Are you sure you want to change the base?

Feature/preceding following signs #2

Uh oh!

Conversation

sourcery-ai-experiments-bot commented Apr 22, 2024

Uh oh!

sourcery-ai-experiments-bot commented Apr 22, 2024

Uh oh!

SourceryAI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants