Feature/preceding following signs #3
Conversation
* Added method to mongo_sign_repository for getting preceding signs
|
This is a benchmark review for experiment This pull request was cloned from Experiment configurationreview_config:
# User configuration for the review
# - benchmark - use the user config from the benchmark reviews
# - <value> - use the value directly
user_config:
enable_ai_review: true
enable_rule_comments: false
enable_complexity_comments: benchmark
enable_docstring_comments: benchmark
enable_security_comments: benchmark
enable_tests_comments: benchmark
enable_comment_suggestions: benchmark
enable_approvals: true
ai_review_config:
# The model responses to use for the experiment
# - benchmark - use the model responses from the benchmark reviews
# - llm - call the language model to generate responses
model_responses:
comments_model: benchmark
comment_validation_model: benchmark
comment_suggestion_model: benchmark
complexity_model: benchmark
docstrings_model: benchmark
security_model: benchmark
tests_model: benchmark
# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/simnova/ownercommunity/pull/73
- https://github.com/wassupluke/recipe-emailer/pull/20
- https://github.com/erxes/erxes/pull/5153
- https://github.com/wassupluke/recipe-emailer/pull/19
- https://github.com/gdsfactory/kfactory/pull/298
- https://github.com/UCL/dxss/pull/63
- https://github.com/wassupluke/recipe-emailer/pull/22
- https://github.com/jquagga/ttt/pull/78
- https://github.com/megasanjay/scholar-stack-mvp/pull/159
- https://github.com/iphysresearch/Eryn/pull/1
- https://github.com/jquagga/ttt/pull/67
- https://github.com/yaitoo/sqle/pull/42
- https://github.com/fairdataihub/fairdataihub.org/pull/620
- https://github.com/jquagga/ttt/pull/75
- https://github.com/jkool702/openwrt/pull/41
- https://github.com/osama1998H/spms/pull/57
- https://github.com/simnova/ownercommunity/pull/75
- https://github.com/dciborow/action-pylint/pull/14
- https://github.com/strawberry-graphql/strawberry/pull/3469
- https://github.com/DevCycleHQ/go-server-sdk/pull/248
- https://github.com/shreejitverma/MScFE690-Capstone/pull/7
- https://github.com/jquagga/ttt/pull/76
- https://github.com/jquagga/ttt/pull/79
- https://github.com/Bilbottom/grid-hooks/pull/7
- https://github.com/wassupluke/recipe-emailer/pull/21
- https://github.com/jquagga/ttt/pull/73
- https://github.com/gdsfactory/kfactory/pull/300
- https://github.com/usama-maxenius/image-editor/pull/71
- https://github.com/gdsfactory/kfactory/pull/301
- https://github.com/osama1998H/spms/pull/56
- https://github.com/okisdev/ChatChat/pull/319
- https://github.com/wassupluke/recipe-emailer/pull/24
- https://github.com/ShiroePL/EasternTalesShelf/pull/44
- https://github.com/youandvern/efficalc/pull/13
- https://github.com/gdsfactory/gdsfactory/pull/2694
- https://github.com/0ussamaBernou/my-portfolio/pull/6
- https://github.com/0ussamaBernou/my-portfolio/pull/8
- https://github.com/wassupluke/recipe-emailer/pull/29
- https://github.com/shreejitverma/MScFE690-Capstone/pull/6
- https://github.com/albumentations-team/albumentations/pull/1679
- https://github.com/osism/python-osism/pull/869
- https://github.com/ElectronicBabylonianLiterature/ebl-api/pull/546
- https://github.com/jquagga/ttt/pull/70
- https://github.com/wassupluke/recipe-emailer/pull/23
- https://github.com/erxes/erxes/pull/5152
- https://github.com/edsonportosilva/OptiCommPy/pull/22
- https://github.com/jquagga/ttt/pull/77
- https://github.com/ShiroePL/EasternTalesShelf/pull/45
- https://github.com/itzlayz/teagram-tl/pull/22
- https://github.com/wassupluke/recipe-emailer/pull/15
review_comment_labels:
- label: correct
question: Is this comment correct?
- label: helpful
question: Is this comment helpful?
- label: comment-type
question: Is the comment type correct?
- label: comment-area
question: Is the comment area correct?
- label: llm-test
question: Should this comment become an LLM test?
# Benchmark reviews generated by running
# python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews: []
|
SourceryAI
left a comment
SourceryAI
left a comment
There was a problem hiding this comment.
Hey @sourcery-ai-experiments-bot - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| data = self._collection.find_one_by_id(name) | ||
| return cast(Sign, SignSchema(unknown=EXCLUDE).load(data)) | ||
|
|
||
| def find_signs_by_order(self, name: SignName, order: str, sort_era: str) -> Sign: |
There was a problem hiding this comment.
issue (code_clarification): Return type of 'find_signs_by_order' should be List[Sign] instead of Sign.
The method appears to return a list of signs, not a single sign, as indicated by the aggregation and grouping in the MongoDB query.
There was a problem hiding this comment.
Should this comment become an LLM test?
| return cast(Sign, SignSchema(unknown=EXCLUDE).load(data)) | ||
|
|
||
| def find_signs_by_order(self, name: SignName, order: str, sort_era: str) -> Sign: | ||
| key = self._collection.find_one_by_id(name)["sortKeys"][sort_era][0] |
There was a problem hiding this comment.
issue (edge_case_not_handled): Potential risk of KeyError if 'sortKeys' or 'sort_era' does not exist.
Consider adding error handling or checks to ensure the keys exist before accessing them to avoid runtime errors.
There was a problem hiding this comment.
Should this comment become an LLM test?
| def on_get(self, req, resp, sign_name, order, sort_era): | ||
| resp.media = self.sign_repository.find_signs_by_order( | ||
| sign_name, order, sort_era |
There was a problem hiding this comment.
issue (testing): Missing test cases for the new endpoint.
The PR introduces a new endpoint but does not include any tests for it. It's crucial to add unit and integration tests to verify that the endpoint behaves as expected under various scenarios, including edge cases and error handling.
There was a problem hiding this comment.
Should this comment become an LLM test?
E.g., "/signs/BAR/following/NeoAssyrianOffset"