Skip to content

Conversation

@ocaisa
Copy link

@ocaisa ocaisa commented Apr 19, 2017

Avg response time coverage on master
Issue Stats Codecov branch

Summary of changes

Added a missing space to the mpif90 compile line of GETTING_STARTED.md, fixed an OpenCoarry typo in README.md

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe: Typo fix

I certify that:

  • I have reviewed the contributing guidelines
  • If this PR is a work in progress I have added WIP: to the
    beginning of the PR title
  • If this PR is problematic for any reason, I have added
    DO NOT MERGE: to the beginning of the title
  • The branch name and title of this PR contains the text
    issue-<#> where <#> is replaced by the issue that this PR
    is addressing
  • I have deleted trailing white space on any lines that this PR
    touches
  • I have used spaces for indentation on any lines that this PR
    touches
  • I have included some comments to explain non-obvious code
    changes
  • I have run the tests localy (ctest) and all tests pass
  • Each commit is a logically atomic, self-consistent, cohesive
    set of changes
  • The commit message should follow these guidelines:
    • First line is directive phrase, starting with a capitalized
      imperative verb, and is no longer than 50 characters
      summarizing your commit
    • Next line, if necessary is blank
    • Following lines are all wrapped at 72 characters and can
      include additional paragraphs, bulleted lists, etc.
    • Use Github keywords where appropriate, to indicate the
      commit resolves an open issue.
  • I have signed Contributor License Agreement (CLA) by
    clicking the "details" link to the right of the licence/cla
    check and following the directions on the CLA assistant webpage
  • I have ensured that the test coverage hasn't gone down and added new unit tests to cover an new code added to the library

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2017

CLA assistant check
All committers have signed the CLA.

@ocaisa
Copy link
Author

ocaisa commented Apr 19, 2017

I didn't open an issue for this because a typo fix seems too trivial for that. Rather than bend the contributor rules, if you prefer you can fix the typos directly yourself and close this issue.

@codecov
Copy link

codecov bot commented Apr 19, 2017

Codecov Report

Merging #362 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   46.22%   46.22%           
=======================================
  Files           3        3           
  Lines        1045     1045           
  Branches      201      201           
=======================================
  Hits          483      483           
  Misses        483      483           
  Partials       79       79

@zbeekman
Copy link
Collaborator

Thanks so much! Yes I think I'll commit these changes directly myself, if you don't mind.

@ocaisa
Copy link
Author

ocaisa commented Apr 19, 2017

NP, I'll leave it to you to close the PR when you're done.

zbeekman added a commit that referenced this pull request Apr 19, 2017
 Thanks to @ocaisa for pointing these out.

 Closes #362

 [ci-skip]
@zbeekman zbeekman mentioned this pull request Apr 19, 2017
20 tasks
@zbeekman zbeekman self-assigned this Apr 19, 2017
zbeekman added a commit that referenced this pull request Apr 19, 2017
@ocaisa ocaisa deleted the fix_md_typos branch April 19, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants