fix: remove forced space by color #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall-davis
previously approved these changes
Jan 14, 2021
Vacoris
previously approved these changes
Jan 14, 2021
Contributor
There was a problem hiding this comment.
@iBotPeaches this works, but noticed you didn't also update the {} wrapping for the
Would recommend that for consistency and possibly changing the ${NO_COLOR} to ${RESET_FONT} or ${RESET_TEXT} as the \033[0m is actually reset foreground/background attributes.
iBotPeaches
dismissed stale reviews from Vacoris and marshall-davis
via
fb0f7df
Member
Author
Swapped to |
Vacoris
approved these changes
Jan 14, 2021
marshall-davis
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more forced space. Aligned perfectly.
fixes: #15