Fixed websocket handshake issue with latest Firefox#205
Merged
auscaster merged 1 commit intosourcey:masterfrom Dec 4, 2017
Merged
Fixed websocket handshake issue with latest Firefox#205auscaster merged 1 commit intosourcey:masterfrom
auscaster merged 1 commit intosourcey:masterfrom
Conversation
Member
|
Hey there, thanks for this. I'll push this for now and make a note for future optimisation! Cheers |
auscaster
added a commit
that referenced
this pull request
Mar 23, 2026
Fixed websocket handshake issue with latest Firefox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have encountered that websocket handshake is not working with latest Firefox.
The reason is in "Connection" header that is send by Firefox, instead of having value "upgrade", it has "keep-alive, Upgrade". Maybe it is a bit ugly fix, but I didn't want to use find or regular expression to check "Connection" header value in single statement for multiple browsers, in order to avoid any potential issues with using word "upgrade" inside "Connection" header.