Fix logic error when calling _encoder.init()#230
Merged
auscaster merged 1 commit intosourcey:masterfrom Mar 9, 2018
Merged
Conversation
R-Gerard
force-pushed
the
streamrecorder_init
branch
from
3e563b7 to
a899696
Compare
Member
|
Looks good, thanks for the contribution! 👍 |
auscaster
added a commit
that referenced
this pull request
Mar 23, 2026
Fix logic error when calling _encoder.init()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
StreamRecordernever calls_encoder.init()when recording both video and audio tracks. Specifically,StreamRecorderexpects one of the booleans to be true and the other to be false exactly once so that it can call theinitfunction, however in my observations both values start as true then both flip to false.This PR separates out the init logic from
_awaitingVideoand_awaitingAudioto callinitexactly once.