Fixed usage of old-version webrtc::VideoFrame#271
Merged
auscaster merged 1 commit intosourcey:masterfrom Jun 27, 2019
Merged
Conversation
In newer versions(including webrtc-22215-ab42706) of webrtc methods DataY (and DataU, DataV) moved from VideoFrameBuffer to PlanarYuv8Buffer which is implemented by I420Buffer. To access instance of I420Buffer GetI420() should be called.
Member
|
Thank, glad to merge this in 👍 |
auscaster
added a commit
that referenced
this pull request
Mar 23, 2026
Fixed usage of old-version webrtc::VideoFrame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This examples could not be compiled right now due to error:
"In member function 'virtual void scy::webrtc::ObjectDetector::OnFrame(const webrtc::VideoFrame&)': 'class webrtc::VideoFrameBuffer' has no member named 'DataY'In newer versions of webrtc(including webrtc-22215-ab42706 which is used in libsourcey) methods
DataY(andDataU,DataV) moved fromVideoFrameBuffertoPlanarYuv8Bufferwhich is implemented byI420Buffer. To access instance ofI420BufferGetI420()should be called.