Fixed init script change reloading#28
Merged
bflad merged 1 commit intosous-chefs:masterfrom Nov 18, 2013
Merged
Conversation
When Chef changes init script, for example add bind_uri, restart doesn't load the command line arguments. Need to stop and start to get changes affect.
Contributor
|
I'll be able to look at this further tomorrow |
Contributor
|
Okay, yeah, definitely an oddity with Upstart: http://upstart.ubuntu.com/faq.html#reload I'm going to merge this then refactor slightly to use initctl as a service instead with a notify reload immediately if possible (this will be useful for an future enhancement to optionally add Upstart jobs for containers). |
bflad
added a commit
that referenced
this pull request
Nov 18, 2013
Fixed init script change reloading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Chef changes init script, for example add bind_uri, restart
doesn't load the command line arguments. Need to stop and start to
get changes affect.
Demo: