feat: proper NixOS and Arch Linux packaging integrations#13
Merged
Conversation
NixOS: - packaging/nix/default.nix: patch systemd unit ExecStart paths for Nix store (/bin/visaged), add doCheck phase running unit tests - packaging/nix/module.nix: full NixOS module with declarative options — services.visage.enable, modelDir, dbPath, camera, similarityThreshold, logLevel, pam.enable. Handles systemd (hardened), D-Bus policy, PAM integration, tmpfiles for /var/lib/visage, and suspend/resume service - flake.nix: repo-root flake exposing packages.visage, devShells.default (with rust-analyzer, cargo-deb, cargo-watch), and nixosModules.default Arch Linux (AUR): - PKGBUILD: add check() running unit tests, backup array for faces.db, provides/conflicts metadata, explicit systemd dependency, export CARGO_TARGET_DIR for reproducible builds - visage.install: structured 4-step post_install with numbered setup guide and PAM instructions, post_upgrade with daemon restart and re-enrollment guidance for pre-0.3.0 upgrades, post_remove with manual PAM cleanup reminder Docs: - README.md: restructure Installation as multi-distro with Ubuntu/Debian, NixOS (flake), and Arch Linux (AUR) sections - operations-guide.md: add NixOS and Arch install paths with PAM notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Properly implements the NixOS and Arch Linux packaging that previously existed as untested scaffolds.
NixOS
packaging/nix/default.nix— patches systemd unitExecStartpaths for the Nix store ($out/bin/visaged), addsdoCheckphase runningcargo test --workspace --libpackaging/nix/module.nix(new) — full NixOS module with declarative options:services.visage.enable— one-line activationmodelDir,dbPath,camera,similarityThreshold,logLevelpam.enable— configures PAM for sudo + login with face-before-passwordvisaged.service)services.dbus.packages/var/lib/visageflake.nix(new, repo root) — exposespackages.visage,devShells.default(rust-analyzer, cargo-deb, cargo-watch),nixosModules.defaultArch Linux (AUR)
PKGBUILD— addscheck()function (unit tests),backuparray (faces.db),provides/conflicts, explicitsystemddep,CARGO_TARGET_DIRexportvisage.install— rewritten with:post_installwith numbered setup guide and exact PAM linepost_upgradewith daemon restart and pre-0.3.0 re-enrollment guidancepost_removewith manual PAM cleanup reminder and data retention noteDocs
Testing
cargo test --workspace: 59/59 passcargo clippy --workspace -- -D warnings: cleanChecklist
cargo fmt --all -- --checkpassescargo clippy --workspace -- -D warningspassescargo test --workspacepasses