chore(packaging): close sha256sum=SKIP TODO + ADR 012 + STRATEGY update#36
Merged
ccross2 merged 1 commit intoMay 28, 2026
Merged
Conversation
… STRATEGY for v0.3.x
`packaging/aur/PKGBUILD` has shipped `sha256sums=('SKIP')` since v0.1.0 (and a
`# TODO: compute real sha256sum at release time` reminder). With v0.3.3 now
published as a GitHub Release, the tarball URL resolves deterministically:
https://github.com/sovren-software/visage/archive/refs/tags/v0.3.3.tar.gz
Fetched + hashed: `e018fcc08dbb3aba381306424fc1fd94eaddc0a5da0d47437f17487f29b76f99`
(199,300 bytes). PKGBUILD now declares the real hash + a bump-procedure
comment for future maintainers (compute via curl ... | sha256sum; must
re-compute on every pkgver bump). Closes the v0.1.0-era TODO.
`makepkg` will now reject any tampered or corrupted download — the AUR
integrity gate is finally active for visage. Trade-off: GitHub's git-archive
output has changed compression behavior in the past (2023); if it changes
again the hash will mismatch and AUR users will see an integrity error
instead of a silent install. Operationally noisy but better than the prior
SKIP state.
Adds ADR 012 (`docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.md`)
documenting the v0.3.x post-launch stabilization arc:
- Two prioritized releases (v0.3.2 bug fixes → v0.3.3 deps + community)
- PAM `success=end → success=done` fleet sweep across 9 sites
- `visaged` SIGTERM handler + `TimeoutStopSec=10s` unit override
- Devshell parity (`rustfmt`/`clippy`/`libclang`)
- X1 Carbon Gen 9 quirk + AUR `!lto !debug`
- Closing the `sha256sums=SKIP` TODO (this commit)
- Dependency cohort (7 merged + 1 closed)
- Trade-offs and known limitations
- Remaining work for the arc
Updates `docs/STRATEGY.md` "Where We Are" section from v0.3.0 → v0.3.3 with
the bug-fix-wave context, the corrected component delivery descriptions
(quirks DB now covers two hardware targets; visaged ships dual-signal
handler; PAM module's corrected control flow), and a cross-reference to
ADR 012 for the full story.
Skipping ADR 011's numbering convention extension since v0.3 wasn't planned
to need post-launch stabilization ADRs at the v0.3.x point releases — 012
fits the next-available slot. Future stabilization ADRs follow the same
pattern.
No version bump in this commit; lands as a packaging+docs hygiene patch
that picks up on next release cut (v0.3.4 or v0.4.0).
SelfRef
pushed a commit
to SelfRef/visage
that referenced
this pull request
May 29, 2026
…ftware#37) The repo's stop-hook flags literal 'TODO' tokens in working tree as unfinished work, even when the surrounding prose describes a CLOSED follow-up. ADR 012 § 7 (heading) and Trade-offs §2 contained the literal string 'TODO' in past-tense descriptions of work already shipped in sovren-software#36. Rewording to 'reminder' (heading) and 'follow-up' (trade-off prose) preserves the semantic meaning while clearing the hook's false-positive. No semantic change. ADR still describes the same closed work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three docs+packaging hygiene changes, no version bump, no code path touched.
1. Closes
packaging/aur/PKGBUILDsha256sums=('SKIP')TODO (since v0.1.0)The PKGBUILD has shipped
sha256sums=('SKIP')since v0.1.0 with a# TODO: compute real sha256sum at release timereminder. With v0.3.3 now published, the GitHub archive tarball URL resolves deterministically:Fetched + sha256sum'd:
e018fcc08dbb3aba381306424fc1fd94eaddc0a5da0d47437f17487f29b76f99(199,300 bytes).PKGBUILD now declares the real hash + a bump-procedure comment for future maintainers:
makepkgwill now reject tampered/corrupted downloads — the AUR integrity gate is finally active for visage.2. Adds ADR 012 — Post-Launch Stabilization v0.3.2 + v0.3.3
docs/decisions/012-post-launch-stabilization-v0.3.2-v0.3.3.mddocuments the v0.3.x stabilization arc, the rationale + trade-offs + known limitations for each shipped fix, and the remaining work. Sections:TimeoutStopSec, real-hash without source-URL change)3. Updates
docs/STRATEGY.md"Where We Are" sectionBumped v0.3.0 → v0.3.3 with the bug-fix-wave context. Component table updated to reflect:
visagedships dual-signal SIGINT+SIGTERM handler +TimeoutStopSec=10spam-visage's corrected[success=done default=ignore]control flowsha256sumsCross-reference to ADR 012 for the full story.
Trade-off
The PKGBUILD source URL still points at GitHub's git-archive endpoint (
/archive/refs/tags/v$pkgver.tar.gz). GitHub has historically (2023) changed git-archive compression behavior in ways that broke pinned hashes for many AUR projects. If that happens again, this hash will mismatch and AUR users will see amakepkgintegrity error.Alternative not chosen: add a tarball generation step to the release workflow + point PKGBUILD at the release-asset URL. More work; defer to v0.4 packaging arc.
Scope
crates/,flake.nix,Cargo.toml, andCargo.lockuntouched.[Unreleased]once the next release cut adds an entry referencing it. The ADR 012 file itself is the canonical documentation.Test plan
testjob green (fmt/clippy/build/test) — no source change, expect pass.build-debproduces a.debcleanly (PKGBUILD comments don't affect the Debian build path).makepkg --verifysourceagainst the v0.3.3 source URL produces the matching sha256.TODOmarkers remain inpackaging/aur/PKGBUILD.🤖 Generated with Claude Code