fixed version setting of deb packages#433
Merged
WadeBarnes merged 1 commit intosovrin-foundation:ubuntu-20.04from Sep 8, 2022
Merged
fixed version setting of deb packages#433WadeBarnes merged 1 commit intosovrin-foundation:ubuntu-20.04from
WadeBarnes merged 1 commit intosovrin-foundation:ubuntu-20.04from
Conversation
pSchlarb
force-pushed
the
GHARefactoring
branch
3 times, most recently
from
a55254e to
2cf2774
Compare
WadeBarnes
requested changes
Sep 8, 2022
Member
WadeBarnes
left a comment
WadeBarnes
left a comment
There was a problem hiding this comment.
I don't think we need getVersion.py. updateVersion.py determines and sets the version for both sovtoken and sovtokenfees consistently.
I think the better approach would be to determine the version number once and then pass that along in the workflow, similar to what we've done with indy-node and indy-plenum. Perhaps have the version number returned by updateVersion.py so it can be used later in the workflows.
pSchlarb
force-pushed
the
GHARefactoring
branch
3 times, most recently
from
6353417 to
f2fa5f9
Compare
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
pSchlarb
force-pushed
the
GHARefactoring
branch
from
f2fa5f9 to
8821f4c
Compare
WadeBarnes
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pSchlarb p.schlarb@esatus.com