Fix for pagination in multilingual (wpml) directory#1184
Closed
AbyssWaIker wants to merge 1 commit intosovware:alphafrom
Closed
Fix for pagination in multilingual (wpml) directory#1184AbyssWaIker wants to merge 1 commit intosovware:alphafrom
AbyssWaIker wants to merge 1 commit intosovware:alphafrom
Conversation
In our wpml setup we have languages in separate "directories" (like "site", "site/pt-pr", "site/pt-br', "site/ru", "site/uk").
So when (at line 62) we attempt to remove home_url ("site/uk") from link ("site/permalink") it doesn't find the string and leaves the whole site address inside "pages" rewrite rule.
Leading to 404 when we our non english speaking visitors are trying to see page 2 of directory.
AbyssWaIker
changed the title
Contributor
|
Hi @AbyssWaIker, Thanks for your contribution. As we have an integration plugin for WPML, this code needs to be placed in this plugin. And we are going to add a hook in the core plugin. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our wpml setup we have languages in separate "directories" (like "site", "site/pt-pr", "site/pt-br', "site/ru", "site/uk").
So when (at line 62) we attempt to remove home_url ("site/uk") from link ("site/permalink") it doesn't find the string and leaves the whole site address inside "pages" rewrite rule.
Leading to 404 when we our non english speaking visitors are trying to see page 2 of directory.