Skip to content

Icon support added for legacy templates#1192

Merged
vairafiq merged 15 commits intoalphafrom
icon/legacy
Sep 21, 2022
Merged

Icon support added for legacy templates#1192
vairafiq merged 15 commits intoalphafrom
icon/legacy

Conversation

@kowsar89
Copy link
Contributor

@kowsar89 kowsar89 commented Sep 13, 2022

How to test:

  1. Copy directorist v7.3.3 templates in your theme.
  2. Enable "Legacy Icon Support" from settings.
  3. All icons should be displayed in front-end.

@kowsar89 kowsar89 modified the milestones: v7.3.4, v7.4.0 Sep 13, 2022
@vairafiq vairafiq requested a review from obiPlabon September 18, 2022 03:20
'type' => 'toggle',
'label' => __( 'Legacy Icon Support', 'directorist' ),
'value' => false,
'description' => sprintf( __( 'Icon support for legacy v7.3.3 templates. Enable this only if there are outdated directorist templates in your theme, you can check them <a href="%s" target="__blank">here</a>.<br/>Note: This setting is temporary and will be removed in the future.', 'directorist' ), menu_page_url( 'directorist-status', false ) . '#atbds_template' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target="__blank" there's a typo. Please use a single underscore instead of a double.

Copy link
Contributor

@obiPlabon obiPlabon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@vairafiq vairafiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

@vairafiq vairafiq merged commit f2178c0 into alpha Sep 21, 2022
@vairafiq vairafiq deleted the icon/legacy branch September 21, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants