Skip to content

fixed broken layout for popular and simialr listing category#1197

Merged
kowsar89 merged 19 commits intosovware:alphafrom
M4hd1BD:fix/pop/sim-widget-category-layout
Nov 9, 2022
Merged

fixed broken layout for popular and simialr listing category#1197
kowsar89 merged 19 commits intosovware:alphafrom
M4hd1BD:fix/pop/sim-widget-category-layout

Conversation

@M4hd1BD
Copy link
Copy Markdown
Contributor

@M4hd1BD M4hd1BD commented Sep 18, 2022

@M4hd1BD M4hd1BD requested a review from kowsar89 as a code owner September 18, 2022 06:26
@vairafiq vairafiq added this to the v7.4.1 milestone Sep 18, 2022
…ix/pop/sim-widget-category-layout

sync with alpha
@kowsar89 kowsar89 modified the milestones: Others, 7.4.3 Oct 30, 2022
@kowsar89 kowsar89 self-assigned this Oct 31, 2022
@kowsar89 kowsar89 assigned M4hd1BD and unassigned kowsar89 Oct 31, 2022
@kowsar89 kowsar89 removed the request for review from vairafiq October 31, 2022 07:06
Copy link
Copy Markdown
Contributor

@kowsar89 kowsar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@kowsar89 kowsar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix php notice http://prntscr.com/hCyem8xkGwfn
  2. Use correct node/npm version when building: http://prntscr.com/Wru19-JzxcAJ
  3. Update template version number
  4. Sync with alpha

Copy link
Copy Markdown
Contributor

@kowsar89 kowsar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M4hd1BD M4hd1BD requested a review from kowsar89 November 2, 2022 07:55
Copy link
Copy Markdown
Contributor

@kowsar89 kowsar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M4hd1BD
Copy link
Copy Markdown
Contributor Author

M4hd1BD commented Nov 6, 2022

Few changes: http://prntscr.com/U_fjiOttBMj3

Adjusted.

@M4hd1BD M4hd1BD requested a review from kowsar89 November 6, 2022 01:25
@kowsar89 kowsar89 requested a review from devShamim November 6, 2022 04:50
Copy link
Copy Markdown
Member

@devShamim devShamim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to test with different themes
https://prnt.sc/Py1TyBoPyV_s

@M4hd1BD
Copy link
Copy Markdown
Contributor Author

M4hd1BD commented Nov 6, 2022

need to test with different themes https://prnt.sc/Py1TyBoPyV_s

Improved.

@M4hd1BD M4hd1BD requested a review from devShamim November 6, 2022 09:32
devShamim
devShamim previously approved these changes Nov 7, 2022
Copy link
Copy Markdown
Member

@devShamim devShamim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Contributor

@kowsar89 kowsar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few style adjustment: http://prntscr.com/tYz0ZmKwm7Sw

Copy link
Copy Markdown
Contributor

@kowsar89 kowsar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme: Twenty Twenty-Three
Style broken: http://prntscr.com/ULsYd4C3aVzT

@kowsar89 kowsar89 merged commit f039bc2 into sovware:alpha Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants