fix(security): Unauthenticated shell command injection in todo image processing#1
Open
sozercan wants to merge 1 commit into
Open
fix(security): Unauthenticated shell command injection in todo image processing#1sozercan wants to merge 1 commit into
sozercan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security remediation for finding
fnd_be61bc01aedd.Summary:
POST /create accepts attacker-controlled markdown image content, extracts a URL with a broad regex, and concatenates it into child_process.exec('identify ' + url). Because the command is executed through the shell with no quoting or argument separation, shell metacharacters in the captured URL can trigger arbitrary command execution on the app host.
Root cause:
Untrusted request data is interpolated into a shell command string and executed via exec().
Remediation guidance:
Avoid the shell entirely: parse and validate the URL, then use execFile/spawn with a fixed argument vector or remove the external command dependency.