refactor: unify retry execution flow #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 98.83% 99.09% +0.26%
==========================================
Files 10 10
Lines 512 661 +149
==========================================
+ Hits 506 655 +149
Misses 6 6
|
Removes code duplication by merging the initial attempt and subsequent retries into a single `while` loop Changes: - Replaces the separate initial call and `for-in` loop with a manual iterator approach. - Centralizes the closure execution, error handling, and cancellation checks into one block. - Improves code readability and maintainability without altering external behavior.
ns-vasilev
force-pushed
the
refactor/simplify-retry-logic
branch
from
79ebc5f to
1e7721a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.