Skip to content

feat: make IValidatorError conform to LocalizedError#113

Merged
ns-vasilev merged 1 commit intomainfrom
feature/localized-error
Feb 16, 2026
Merged

feat: make IValidatorError conform to LocalizedError#113
ns-vasilev merged 1 commit intomainfrom
feature/localized-error

Conversation

@ns-vasilev
Copy link
Member

No description provided.

@ns-vasilev ns-vasilev self-assigned this Feb 16, 2026
@ns-vasilev ns-vasilev requested a review from a team as a code owner February 16, 2026 15:19
@spacecode-github-bot
Copy link

2 Warnings
⚠️ This PR may need tests. Consider adding test coverage.
⚠️ Public API changed but no documentation updates found
1 Message
📖

ℹ️ Some source files have tests that weren't updated:

  • URLValidationRule → test file exists: URLValidationRuleTests.swift (consider updating if logic changed)

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.64%. Comparing base (b87a3da) to head (4ba863c).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ore/Classes/Core/Interfaces/IValidationError.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   93.72%   93.64%   -0.08%     
==========================================
  Files          56       57       +1     
  Lines        2756     2767      +11     
==========================================
+ Hits         2583     2591       +8     
- Misses        173      176       +3     
Files with missing lines Coverage Δ
...e/Classes/Extensions/String+IValidationError.swift 100.00% <100.00%> (ø)
...alidatorCore/Classes/Rules/URLValidationRule.swift 100.00% <ø> (ø)
...ses/AppKit/Extensions/NSTextField+Validation.swift 60.87% <100.00%> (+3.73%) ⬆️
...sses/UIKit/Extensions/UITextField+Validation.swift 69.23% <100.00%> (+5.59%) ⬆️
...asses/UIKit/Extensions/UITextView+Validation.swift 58.33% <100.00%> (+3.79%) ⬆️
...ore/Classes/Core/Interfaces/IValidationError.swift 0.00% <0.00%> (ø)

@ns-vasilev ns-vasilev merged commit 03b2cac into main Feb 16, 2026
30 checks passed
@ns-vasilev ns-vasilev deleted the feature/localized-error branch February 16, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants