build: include umbra-prover binary in flow-server image#323
Merged
Conversation
The @spo/umbra.* Bun nodes shell out to a native Rust binary (crates/umbra-prover) for Groth16 proof generation. resolveProverBin() in cmds-bun/src/umbra/umbra_common.ts falls back to PATH lookup when target/debug|release/ copies aren't present, but the deploy container had neither — so register/claim/sweep flows failed with "Executable not found in $PATH: umbra-prover". Build the binary alongside flow-server in the Rust stage, copy it into the runtime image, and add it to the ldd-verification step so we catch missing shared libs the same way we do for flow-server/deno/bun. Seen in: flow_run ea68e2e5 from @spo/umbra.umbra_register.0.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@spo/umbra.*Bun nodes shell out to a native Rust binary (crates/umbra-prover) for Groth16 proof generation, but the deploy Dockerfile only builds and packagesflow-server.resolveProverBin()incmds-bun/src/umbra/umbra_common.tsfalls back to PATH when workspace paths are missing, which in production fails with:Seen in flow_run ea68e2e5-282e-4234-b9cc-dd8aed171239 from
@spo/umbra.umbra_register.0.1.Changes
umbra-proveralongsideflow-serverin the Rust stage (cargo build --bin flow-server --bin umbra-prover)/usr/local/bin/umbra-proverlddverification step so we catch missing shared libs the same way as the other binariesTest plan
flow-server:<sha>image containing both binaries/flow/start/333ebbab-acf9-41e3-95f1-31498105917f(Umbra treasury register on mainnet) — expectstatus: "success"with 3 comma-separated tx signatures inoutput.signature