Skip to content

Upgrade slack-morphism to 2.19#516

Merged
jamiepine merged 2 commits intospacedriveapp:mainfrom
chandima:fix/upgrade-slack-morphism
Apr 2, 2026
Merged

Upgrade slack-morphism to 2.19#516
jamiepine merged 2 commits intospacedriveapp:mainfrom
chandima:fix/upgrade-slack-morphism

Conversation

@chandima
Copy link
Copy Markdown
Contributor

Fixes #515.

Slack messages were failing to send intermittently — 132 failures in one day, all sizes. Bot token verified working via curl, so the issue was in the HTTP client layer.

Bumping slack-morphism from 2.17 to 2.19 resolves it. The upgrade pulls in tokio-tungstenite 0.29 and signal-hook 0.4, which likely fix the stale connection / WebSocket reset issues we were seeing.

Tested with multiple messages including a full worker pipeline (arxiv paper review → browser tools → 3.5KB result delivered via retrigger). Zero send failures, zero retries needed.

Updates slack-morphism to latest version which includes:
- tokio-tungstenite 0.29.0 (fixes potential WebSocket ResetWithoutClosingHandshake)
- signal-hook 0.4.x updates
- Flexible paging API and new files API methods

This addresses intermittent Slack message send failures caused by
HTTP client issues in the older version. See spacedriveapp#515.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • Cargo.toml is excluded by !**/*.toml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bcb44680-9f12-4a8f-983b-462cbc24ecb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jamiepine jamiepine merged commit 4b2f0d7 into spacedriveapp:main Apr 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack messages fail to send intermittently

2 participants