Skip to content

Fix docker build not copying skills folder#590

Merged
jamiepine merged 1 commit intospacedriveapp:mainfrom
andhask:fix-docker-build
May 7, 2026
Merged

Fix docker build not copying skills folder#590
jamiepine merged 1 commit intospacedriveapp:mainfrom
andhask:fix-docker-build

Conversation

@andhask
Copy link
Copy Markdown
Contributor

@andhask andhask commented May 7, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack

Walkthrough

The Dockerfile's builder stage is updated to copy the skills/ directory into the build workspace. This addition ensures the skills directory is available during the Docker image build process, before subsequent copy steps for migrations, documentation, and source code.

Changes

Docker Build Configuration

Layer / File(s) Summary
Builder Configuration
Dockerfile
Builder stage gains COPY skills/ skills/ instruction to include skills directory in the build context before migrations and other assets are copied.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • spacedriveapp/spacebot#316: Both PRs add COPY instructions to the Dockerfile's builder stage to include additional source directories in the build context.

Suggested reviewers

  • jamiepine
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining why the skills/ directory needs to be copied and what issue this fix resolves.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a COPY step for the skills/ directory in the Dockerfile that was missing from the build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile (1)

53-65: 💤 Low value

Update the comment block to document skills/.

Every other copied asset has an inline explanation (# skills/ is needed for ...), but the newly added skills/ directory is undocumented. Add a brief note consistent with the existing style.

📝 Proposed update
-#    docs/ is needed for rust-embed in src/self_awareness.rs.
+#    skills/ is needed for <reason — e.g., rust-embed in src/skills.rs>.
+#    docs/ is needed for rust-embed in src/self_awareness.rs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 53 - 65, Add a comment line documenting the newly
copied skills/ directory in the same style as the other entries: insert a line
like "#    skills/ is needed for <brief reason>" above the COPY lines so the
block includes an explanation for COPY skills/ skills/ (e.g., "#    skills/ is
needed for runtime skill modules referenced by src/..."). Match the existing
formatting and tone.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Dockerfile`:
- Around line 53-65: Add a comment line documenting the newly copied skills/
directory in the same style as the other entries: insert a line like "#   
skills/ is needed for <brief reason>" above the COPY lines so the block includes
an explanation for COPY skills/ skills/ (e.g., "#    skills/ is needed for
runtime skill modules referenced by src/..."). Match the existing formatting and
tone.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44dcd2b3-d7f8-4b07-bb0c-24cd5e18090c

📥 Commits

Reviewing files that changed from the base of the PR and between 51d92c6 and 8e779c7.

📒 Files selected for processing (1)
  • Dockerfile

@jamiepine jamiepine merged commit 21868af into spacedriveapp:main May 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants