Genesis address format - change address type from byte slice to string#173
Merged
abergasov merged 3 commits intoAug 8, 2022
Merged
Conversation
9 tasks
abergasov
changed the title
abergasov
requested review from
dshulyak and
lrettig
and removed request for
dshulyak
Collaborator
|
Please check whether this also needs to change: api/proto/spacemesh/v1/tx_types.proto Lines 61 to 62 in 63f4615 |
abergasov
force-pushed
the
3315-genesis-address-format_api_signature_change
branch
from
cd8a4ad to
f896c52
Compare
Collaborator
|
These are also addresses: api/proto/spacemesh/v1/types.proto Lines 48 to 49 in f896c52 Please check for others |
lrettig
changed the title
7 tasks
dshulyak
reviewed
Aug 5, 2022
| bytes principal = 2; | ||
| bytes template = 3; | ||
| AccountId principal = 2; | ||
| AccountId template = 3; |
Contributor
There was a problem hiding this comment.
i don't know if template should have an hrp. this seems a bit weird. @lrettig what do you think?
Collaborator
There was a problem hiding this comment.
It should. It's a domain-specific thing -- the same address (i.e., bytestr) can exist on many networks, but a template may only be deployed on one, and the HRP specifies the domain.
Collaborator
There was a problem hiding this comment.
I think we can make it optional for both principal and template since HRP is already implied by GENESISID, which the tx is bound to (spacemeshos/pm#135)
dshulyak
approved these changes
Aug 8, 2022
bors Bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Aug 16, 2022
## Motivation <!-- Please mention the issue fixed by this PR or detailed motivation --> Closes #3315 <!-- `Closes #XXXX, closes #XXXX, ...` links mentioned issues to this PR and automatically closes them when this it's merged --> ## Changes * address moved to separate pkg. probably in future will be as independent library * address still array of bytes ([24]byte), but implement `bech32` algorithm. Additional first byte reserved for contain HumanReadablePart of address (now contain info about networkID - test|main net), so result is [25]byte * all api endpoints will be changed to use string instead []byte (related pr spacemeshos/api#173) ## Test Plan unit tests ## TODO <!-- This section should be removed when all items are complete --> - [ ] Explain motivation or link existing issue(s) - [ ] Test changes and document test plan - [ ] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [ ] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [ ] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
changed all address fields from []byte to bech32 string
smt1ru1241...See spacemeshos/go-spacemesh#3315
Closes #172