Skip to content

Sqlite backend #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jan 20, 2025
Merged

Sqlite backend #57

merged 31 commits into from
Jan 20, 2025

Conversation

@buffrr
Copy link
Member

@buffrr buffrr commented Jan 20, 2025 •
edited
Loading

This a large PR as it changes the wallet persistence and touches many parts of the codebase. Changes include:

  1. Switch to the sqlite backend for better stability
  2. Store additional metadata about a transaction such as which tx is a bid, open, transfer ... etc
  3. Watch the mempool for bid replacements to free up locked funds without having to wait for confirmation
  4. listspaces now shows which spaces have been outbid
  5. Use a batched version of bdk to handle issues with conflicting bid transactions
  6. Update bdk to the most recent stable version
  7. Graceful RPC retries
  8. Create extra bidouts to save on tx fees
  9. Add wallet sync checks to make sure spaces and wallet tips are up to date
  10. Several other bug fixes and stability imporvements.

Fixes #53
Fixes #54
Fixes #45

buffrr added 30 commits January 13, 2025 10:09
@buffrr
Update bdk dep & use sqlite backend
8165a19
@buffrr
Clean up formatting & remove obsolete types
abbf463
@buffrr
Add in_mempool helper & tip emission
8a474ba
@buffrr
Store events associated with a transaction
b6bf78a
@buffrr
Unify builder logic and make internal wallet type private
00bac52
@buffrr
Update bdk to most recent version
13fcaf4
@buffrr
Check mempool for dropped bids & wallet sync checks
7ce5457
@buffrr
Apply bdk double spend patch until fixed upstream
bb85bd4
@buffrr
Update integration tests for unconfirmed & fix others
448193c
@buffrr
Add tx events to listtransactions
dfa8f60
@buffrr
Insert txouts for foreign inputs
4053bd4 
Fixes spacesprotocol#53
@buffrr
Create extra bidouts to save on tx fees
235a11a
@buffrr
Make sure wallet is synced during tests
43c2d8f
@buffrr
Add helpful errors when attempting some actions multiple times
5afdc7c
@buffrr
Use block hash for snapshot versioning
6c136ab
@buffrr
Fetcher retry and update in mempool checks
50e2528
@buffrr
Use db for commit signing info + minor updates
a9ff276
@buffrr
Fix build warnings
321374a
@buffrr
Add more test utils
2b35217
@buffrr
Fix wallet builder batch ordering
a2b9a9a
@buffrr
Update integration tests
a55668d
@buffrr
Add more integration tests
d23653f
@buffrr
Add list_watched_spaces
0983b05
@buffrr
Fix wallet load
f4a813e
@buffrr
Fix watched spaces query to include opens
ec26148
@buffrr
Update listspaces to include outbid
5810ba1
@buffrr
Fix insert_checkpoint
8383c39
@buffrr
Increase lookahead to 50
dc16c8f
@buffrr
Update recent events query
8731272
@buffrr
Reintroduce space output exclusion
44c9733
@buffrr buffrr merged commit 6973522 into spacesprotocol:main Jan 20, 2025
1 check passed
@Ximik Ximik mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

@buffrr