Skip to content

w3nco: Fix for gcc@14#55

Merged
tldahlgren merged 3 commits into
spack:developfrom
mathomp4:spack-pr-50821
Jul 8, 2025
Merged

w3nco: Fix for gcc@14#55
tldahlgren merged 3 commits into
spack:developfrom
mathomp4:spack-pr-50821

Conversation

@mathomp4
Copy link
Copy Markdown
Contributor

@mathomp4 mathomp4 commented Jun 6, 2025

Note

This PR was migrated from spack/spack#50821.

Testing with spack and GCC 14 found that w3nco was failing with:

  >> 177    /home/ubuntu/tmpdir/spack-stage/spack-stage-w3nco-2.4.1-f3akx5giiz5svjgkxq4vtv7d4uo7tgqz/spack-src/src/summary.c:259:13: error: implicit declaration of function 'times'; did you mean 'utime
            s'? [-Wimplicit-function-declaration]
     178      259 |       ret = times (&Time_buffer);
     179          |             ^~~~~
     180          |             utimes

Since the recipe puts -Wno-error=implicit-function-declaration for other compilers, I added gcc@14:

NOTE: It's possible older GCC might also need this, but I only have GCC 14 around to test.

mathomp4 and others added 2 commits June 6, 2025 09:00
Copy link
Copy Markdown
Contributor

@t-brown t-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tldahlgren
Copy link
Copy Markdown
Contributor

Looks like container issue with the windows build.

@spackbot-app spackbot-app Bot added the core PR affects Spack core functionality label Jul 7, 2025
@tldahlgren
Copy link
Copy Markdown
Contributor

Let's see if Update branch resolves the problem.

@tldahlgren tldahlgren enabled auto-merge (squash) July 7, 2025 23:17
@tldahlgren tldahlgren self-assigned this Jul 7, 2025
@tldahlgren tldahlgren merged commit b6b5a52 into spack:develop Jul 8, 2025
15 checks passed
G-Ragghianti pushed a commit to G-Ragghianti/spack-packages that referenced this pull request Jul 9, 2025
* w3nco: Fix for gcc@14

* Update var/spack/repos/spack_repo/builtin/packages/w3nco/package.py

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

---------

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
mtaillefumier pushed a commit to mtaillefumier/spack-packages that referenced this pull request Jul 16, 2025
* w3nco: Fix for gcc@14

* Update var/spack/repos/spack_repo/builtin/packages/w3nco/package.py

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

---------

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
jezwilkinson pushed a commit to jezwilkinson/spack-packages that referenced this pull request Jul 21, 2025
* w3nco: Fix for gcc@14

* Update var/spack/repos/spack_repo/builtin/packages/w3nco/package.py

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

---------

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@mathomp4 mathomp4 deleted the spack-pr-50821 branch September 25, 2025 11:48
climbfuji added a commit to climbfuji/spack-packages that referenced this pull request Apr 28, 2026
New variant `fix_rt_linkage` for intel-oneapi-compilers to fix missing symbols in libimf.so/libirc.so (spack-packages spack#4092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants