gfe: protections for CMake 4.0#57
Merged
Merged
Conversation
Contributor
|
Added @haampie based on prior PR. |
tldahlgren
approved these changes
Jul 7, 2025
Contributor
|
It's been weeks so merging. |
G-Ragghianti
pushed a commit
to G-Ragghianti/spack-packages
that referenced
this pull request
Jul 9, 2025
* gfe: protections for CMake 4.0 * Fix bad code
mtaillefumier
pushed a commit
to mtaillefumier/spack-packages
that referenced
this pull request
Jul 16, 2025
* gfe: protections for CMake 4.0 * Fix bad code
jezwilkinson
pushed a commit
to jezwilkinson/spack-packages
that referenced
this pull request
Jul 21, 2025
* gfe: protections for CMake 4.0 * Fix bad code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was migrated from spack/spack#50084.
Users recently found that the GFE libraries:
have some
cmake_minimum_required(VERSION 3.0)calls in the CMake. With CMake 4, this is now an error.Efforts are underway to update all the GFE libraries to use CMake 3.24 as a minimum (which is a version we use in codes that use GFE, so we are comfortable with it).
But until those versions can be tested and released, we need to protect spack users from having failing builds.
You'll note below that
pfunitis a "special" case as a user already found this out and a version, 4.12, was released that can work with CMake 4:but with the upcoming 4.13 we'll move to CMake 3.24 as well.