Skip to content

gfe: protections for CMake 4.0#57

Merged
tldahlgren merged 2 commits into
spack:developfrom
mathomp4:spack-pr-50084
Jul 7, 2025
Merged

gfe: protections for CMake 4.0#57
tldahlgren merged 2 commits into
spack:developfrom
mathomp4:spack-pr-50084

Conversation

@mathomp4
Copy link
Copy Markdown
Contributor

@mathomp4 mathomp4 commented Jun 6, 2025

Note

This PR was migrated from spack/spack#50084.

Users recently found that the GFE libraries:

  • gFTL
  • gFTL-shared
  • fArgParse
  • pFUnit
  • yaFyaml
  • pFlogger

have some cmake_minimum_required(VERSION 3.0) calls in the CMake. With CMake 4, this is now an error.

Efforts are underway to update all the GFE libraries to use CMake 3.24 as a minimum (which is a version we use in codes that use GFE, so we are comfortable with it).

But until those versions can be tested and released, we need to protect spack users from having failing builds.

You'll note below that pfunit is a "special" case as a user already found this out and a version, 4.12, was released that can work with CMake 4:

    depends_on("cmake@3.12:3", type="build", when="@:4.11")
    depends_on("cmake@3.12:", type="build", when="@4.12")
    depends_on("cmake@3.24:", type="build", when="@4.13:")

but with the upcoming 4.13 we'll move to CMake 3.24 as well.

@mathomp4 mathomp4 requested a review from tclune June 9, 2025 17:07
@tldahlgren tldahlgren requested a review from haampie June 10, 2025 01:14
@tldahlgren
Copy link
Copy Markdown
Contributor

Added @haampie based on prior PR.

@tldahlgren tldahlgren added the wait-on-reviewers Waiting on comments from one or more reviewer. label Jun 10, 2025
@tldahlgren
Copy link
Copy Markdown
Contributor

It's been weeks so merging.

@tldahlgren tldahlgren merged commit 4c247eb into spack:develop Jul 7, 2025
16 checks passed
@tldahlgren tldahlgren removed the wait-on-reviewers Waiting on comments from one or more reviewer. label Jul 7, 2025
@tldahlgren tldahlgren self-assigned this Jul 7, 2025
G-Ragghianti pushed a commit to G-Ragghianti/spack-packages that referenced this pull request Jul 9, 2025
* gfe: protections for CMake 4.0

* Fix bad code
mtaillefumier pushed a commit to mtaillefumier/spack-packages that referenced this pull request Jul 16, 2025
* gfe: protections for CMake 4.0

* Fix bad code
jezwilkinson pushed a commit to jezwilkinson/spack-packages that referenced this pull request Jul 21, 2025
* gfe: protections for CMake 4.0

* Fix bad code
@mathomp4 mathomp4 deleted the spack-pr-50084 branch September 25, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants