aocc: help flang find gcc#59
Merged
Merged
Conversation
flang can't find gcc if gcc is installed in a non-standard location. This commit: - Patches flang1 & flang2 with the rpath for libquadmath. - Creates a wrapper script to pass options to flang, since flang.cfg is currently ignored. - Passes `--gcc-toolchain`. - Passes `-Wl,-rpath` so executables can find libquadmath. - Passes `-Wno-unused-command-line-argument` to silence warnings generated by `-Wl,-rpath`, since they can cause problems.
tldahlgren
added
the
waiting-on-maintainer
bernhardkaindl
approved these changes
Aug 6, 2025
Contributor
bernhardkaindl
left a comment
bernhardkaindl
left a comment
There was a problem hiding this comment.
@amd-toolchain-support, see the comment by @nolta, in the resolved discussion thread.
As you're maintaining aocc, is this good to merge by you?
amd-toolchain-support
approved these changes
Aug 18, 2025
Contributor
amd-toolchain-support
left a comment
amd-toolchain-support
left a comment
There was a problem hiding this comment.
These changes looks good,
Contributor
Apologies for delay, |
bernhardkaindl
approved these changes
Aug 22, 2025
Contributor
bernhardkaindl
left a comment
bernhardkaindl
left a comment
There was a problem hiding this comment.
Thanks @amd-toolchain-support, will merge.
paulmelis
pushed a commit
to paulmelis/spack-packages
that referenced
this pull request
Aug 26, 2025
flang can't find gcc if gcc is installed in a non-standard location. This commit: - Patches flang1 & flang2 with the rpath for libquadmath. - Creates a wrapper script to pass options to flang, since flang.cfg is currently ignored. - Passes `--gcc-toolchain`. - Passes `-Wl,-rpath` so executables can find libquadmath. - Passes `-Wno-unused-command-line-argument` to silence warnings generated by `-Wl,-rpath`, since they can cause problems.
mladenivkovic
pushed a commit
to mladenivkovic/spack-packages
that referenced
this pull request
Aug 31, 2025
flang can't find gcc if gcc is installed in a non-standard location. This commit: - Patches flang1 & flang2 with the rpath for libquadmath. - Creates a wrapper script to pass options to flang, since flang.cfg is currently ignored. - Passes `--gcc-toolchain`. - Passes `-Wl,-rpath` so executables can find libquadmath. - Passes `-Wno-unused-command-line-argument` to silence warnings generated by `-Wl,-rpath`, since they can cause problems.
tldahlgren
removed
the
waiting-on-maintainer
climbfuji
added a commit
to climbfuji/spack-packages
that referenced
this pull request
May 7, 2026
bufr: add v12.3.0 (spack#4545)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was migrated from spack/spack#50227.
AOCC
flangcan't findgccifgccis installed in a non-standard location.This commit:
flang1&flang2with the rpath for libquadmath.flang, sinceflang.cfgis currently ignored.--gcc-toolchain.-Wl,-rpathso executables can find libquadmath.-Wno-unused-command-line-argumentto silence warnings generated by-Wl,-rpath, since they can cause problems.