py-libclang: setup.py renamed#807
Conversation
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
wdconinc
left a comment
There was a problem hiding this comment.
Looks good to me. Sorry to have missed this in the recent upgrade of libclang.
Maybe another approach is to prevent detecting llvm as external when llvm-config is missing. This isn't the only case where llvm-config is used. And it's not the only case of a spack package requiring multiple OS packages to satisfy the assumptions (rust = rustc + cargo). |
|
I think we still have to detect it in order to use clang/flang. |
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Extracted out of #39
@rbberger @wdconinc @haampie @skosukhin @trws
Next problem is that the package calls
spec['llvm'].libs, which callsllvm-config, which is not installed in the CI image because we only installed clang/flang. spack/gitlab-runners#67 is one potential fix, but not very robust. Ideally, there would be some way to say thatpy-libclangrequiresllvm+devand Spack would install it itself. Is there any variant or CMake flag that controls whetherllvm-configor the actual library files get installed?