Skip to content

py-libclang: setup.py renamed#807

Merged
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:packages/py-libclang
Aug 2, 2025
Merged

py-libclang: setup.py renamed#807
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:packages/py-libclang

Conversation

@adamjstewart
Copy link
Member

Extracted out of #39

@rbberger @wdconinc @haampie @skosukhin @trws

Next problem is that the package calls spec['llvm'].libs, which calls llvm-config, which is not installed in the CI image because we only installed clang/flang. spack/gitlab-runners#67 is one potential fix, but not very robust. Ideally, there would be some way to say that py-libclang requires llvm+dev and Spack would install it itself. Is there any variant or CMake flag that controls whether llvm-config or the actual library files get installed?

Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry to have missed this in the recent upgrade of libclang.

@wdconinc
Copy link
Contributor

Next problem is that the package calls spec['llvm'].libs, which calls llvm-config, which is not installed in the CI image because we only installed clang/flang. spack/gitlab-runners#67 is one potential fix, but not very robust. Ideally, there would be some way to say that py-libclang requires llvm+dev and Spack would install it itself. Is there any variant or CMake flag that controls whether llvm-config or the actual library files get installed?

Maybe another approach is to prevent detecting llvm as external when llvm-config is missing. This isn't the only case where llvm-config is used. And it's not the only case of a spack package requiring multiple OS packages to satisfy the assumptions (rust = rustc + cargo).

@adamjstewart
Copy link
Member Author

I think we still have to detect it in order to use clang/flang.

@adamjstewart adamjstewart merged commit d49f5ac into spack:develop Aug 2, 2025
16 checks passed
@adamjstewart adamjstewart deleted the packages/py-libclang branch August 2, 2025 10:58
hfbauman pushed a commit to hfbauman/spack-packages that referenced this pull request Aug 12, 2025
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
afzpatel pushed a commit to afzpatel/spack-packages that referenced this pull request Aug 12, 2025
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
mladenivkovic pushed a commit to mladenivkovic/spack-packages that referenced this pull request Aug 31, 2025
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants