py-xhistogram: fix python 3.12 by Chrismarsh · Pull Request #898 · spack/spack-packages

Chrismarsh · 2025-07-31T17:41:37Z

Fixes compatibility with python 3.12.
Patch is from a PR I submitted. The project doesn't look very active so I don't think it's worth waiting for this to be merged in

Chrismarsh · 2025-07-31T17:50:22Z

@spackbot fix style

spackbot-app · 2025-07-31T17:50:24Z

Let me see if I can fix that for you!

spackbot-app · 2025-07-31T17:51:10Z

I was able to run spack style --fix for you!

spack style --fix

repos/spack_repo/builtin/packages/py_xhistogram/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

…ck-packages into package-fix/py-xhistogram

repos/spack_repo/builtin/packages/py_xhistogram/package.py

Chrismarsh · 2025-08-01T18:10:50Z

@spackbot fix style

spackbot-app · 2025-08-01T18:10:53Z

Let me see if I can fix that for you!

spackbot-app · 2025-08-01T18:11:48Z

I was able to run spack style --fix for you!

spack style --fix

repos/spack_repo/builtin/build_systems/autotools.py
repos/spack_repo/builtin/build_systems/gnu.py
repos/spack_repo/builtin/build_systems/oneapi.py
repos/spack_repo/builtin/build_systems/sourceforge.py
repos/spack_repo/builtin/build_systems/sourceware.py
repos/spack_repo/builtin/build_systems/xorg.py
repos/spack_repo/builtin/packages/aluminum/package.py
repos/spack_repo/builtin/packages/ams/package.py
repos/spack_repo/builtin/packages/aotriton/package.py
repos/spack_repo/builtin/packages/armpl_gcc/package.py
repos/spack_repo/builtin/packages/ascent/package.py
repos/spack_repo/builtin/packages/atk/package.py
repos/spack_repo/builtin/packages/augustus/package.py
repos/spack_repo/builtin/packages/axl/package.py
repos/spack_repo/builtin/packages/axom/package.py
repos/spack_repo/builtin/packages/bash/package.py
repos/spack_repo/builtin/packages/bcftools/package.py
repos/spack_repo/builtin/packages/blt/package.py
repos/spack_repo/builtin/packages/bohrium/package.py
repos/spack_repo/builtin/packages/boost/package.py
repos/spack_repo/builtin/packages/care/package.py
repos/spack_repo/builtin/packages/ccs_qcd/package.py
repos/spack_repo/builtin/packages/cgal/package.py
repos/spack_repo/builtin/packages/charmpp/package.py
repos/spack_repo/builtin/packages/conduit/package.py
repos/spack_repo/builtin/packages/cosmomc/package.py
repos/spack_repo/builtin/packages/cp2k/package.py
repos/spack_repo/builtin/packages/dav_sdk/package.py
repos/spack_repo/builtin/packages/dealii/package.py
repos/spack_repo/builtin/packages/dftbplus/package.py
repos/spack_repo/builtin/packages/docbook_xml/package.py
repos/spack_repo/builtin/packages/eccodes/package.py
repos/spack_repo/builtin/packages/eckit/package.py
repos/spack_repo/builtin/packages/ecp_data_vis_sdk/package.py
repos/spack_repo/builtin/packages/elpa/package.py
repos/spack_repo/builtin/packages/esmf/package.py
repos/spack_repo/builtin/packages/exciting/package.py
repos/spack_repo/builtin/packages/flamemaster/package.py
repos/spack_repo/builtin/packages/flann/package.py
repos/spack_repo/builtin/packages/flexi/package.py
repos/spack_repo/builtin/packages/fortrilinos/package.py
repos/spack_repo/builtin/packages/freetype/package.py
repos/spack_repo/builtin/packages/gcc/package.py
repos/spack_repo/builtin/packages/geopm_runtime/package.py
repos/spack_repo/builtin/packages/ghostscript_fonts/package.py
repos/spack_repo/builtin/packages/glib/package.py
repos/spack_repo/builtin/packages/gpu_burn/package.py
repos/spack_repo/builtin/packages/graphviz/package.py
repos/spack_repo/builtin/packages/groff/package.py
repos/spack_repo/builtin/packages/gromacs/package.py
repos/spack_repo/builtin/packages/grpc/package.py
repos/spack_repo/builtin/packages/gtkplus/package.py
repos/spack_repo/builtin/packages/hdf5/package.py
repos/spack_repo/builtin/packages/hicops/package.py
repos/spack_repo/builtin/packages/hiop/package.py
repos/spack_repo/builtin/packages/hipblaslt/package.py
repos/spack_repo/builtin/packages/hpc_beeflow/package.py
repos/spack_repo/builtin/packages/hpctoolkit/package.py
repos/spack_repo/builtin/packages/hwloc/package.py
repos/spack_repo/builtin/packages/hypre_cmake/package.py
repos/spack_repo/builtin/packages/icedtea/package.py
repos/spack_repo/builtin/packages/icu4c/package.py
repos/spack_repo/builtin/packages/jsoncpp/package.py
repos/spack_repo/builtin/packages/jsonnet/package.py
repos/spack_repo/builtin/packages/kentutils/package.py
repos/spack_repo/builtin/packages/lbann/package.py
repos/spack_repo/builtin/packages/lcals/package.py
repos/spack_repo/builtin/packages/libcint/package.py
repos/spack_repo/builtin/packages/libepoxy/package.py
repos/spack_repo/builtin/packages/libint/package.py
repos/spack_repo/builtin/packages/libunwind/package.py
repos/spack_repo/builtin/packages/libxc/package.py
repos/spack_repo/builtin/packages/llvm/package.py
repos/spack_repo/builtin/packages/llvm_doe/package.py
repos/spack_repo/builtin/packages/lmdb/package.py
repos/spack_repo/builtin/packages/madgraph5amc/package.py
repos/spack_repo/builtin/packages/mariadb/package.py
repos/spack_repo/builtin/packages/matio/package.py
repos/spack_repo/builtin/packages/mfem/package.py
repos/spack_repo/builtin/packages/mimalloc/package.py
repos/spack_repo/builtin/packages/mpich/package.py
repos/spack_repo/builtin/packages/mvapich/package.py
repos/spack_repo/builtin/packages/mvapich2/package.py
repos/spack_repo/builtin/packages/mvapich2x/package.py
repos/spack_repo/builtin/packages/mvapich_plus/package.py
repos/spack_repo/builtin/packages/namd/package.py
repos/spack_repo/builtin/packages/ncbi_toolkit/package.py
repos/spack_repo/builtin/packages/nektools/package.py
repos/spack_repo/builtin/packages/networkdirect/package.py
repos/spack_repo/builtin/packages/ngspice/package.py
repos/spack_repo/builtin/packages/nvhpc/package.py
repos/spack_repo/builtin/packages/octopus/package.py
repos/spack_repo/builtin/packages/openmpi/package.py
repos/spack_repo/builtin/packages/opennurbs/package.py
repos/spack_repo/builtin/packages/p3dfft3/package.py
repos/spack_repo/builtin/packages/paradiseo/package.py
repos/spack_repo/builtin/packages/parflow/package.py
repos/spack_repo/builtin/packages/parsec/package.py
repos/spack_repo/builtin/packages/pcre/package.py
repos/spack_repo/builtin/packages/pfind/package.py
repos/spack_repo/builtin/packages/phist/package.py
repos/spack_repo/builtin/packages/picsar/package.py
repos/spack_repo/builtin/packages/pika/package.py
repos/spack_repo/builtin/packages/pism/package.py
repos/spack_repo/builtin/packages/possvm/package.py
repos/spack_repo/builtin/packages/postgis/package.py
repos/spack_repo/builtin/packages/povray/package.py
repos/spack_repo/builtin/packages/py_charm4py/package.py
repos/spack_repo/builtin/packages/py_huggingface_hub/package.py
repos/spack_repo/builtin/packages/py_numpy/package.py
repos/spack_repo/builtin/packages/py_pint_xarray/package.py
repos/spack_repo/builtin/packages/py_uproot/package.py
repos/spack_repo/builtin/packages/py_waves/package.py
repos/spack_repo/builtin/packages/py_xhistogram/package.py
repos/spack_repo/builtin/packages/qmcpack/package.py
repos/spack_repo/builtin/packages/quantum_espresso/package.py
repos/spack_repo/builtin/packages/r3d/package.py
repos/spack_repo/builtin/packages/regcm/package.py
repos/spack_repo/builtin/packages/relion/package.py
repos/spack_repo/builtin/packages/revocap_refiner/package.py
repos/spack_repo/builtin/packages/rocksdb/package.py
repos/spack_repo/builtin/packages/rocm_gdb/package.py
repos/spack_repo/builtin/packages/rocm_validation_suite/package.py
repos/spack_repo/builtin/packages/root/package.py
repos/spack_repo/builtin/packages/s4pred/package.py
repos/spack_repo/builtin/packages/salmon/package.py
repos/spack_repo/builtin/packages/scotch/package.py
repos/spack_repo/builtin/packages/scr/package.py
repos/spack_repo/builtin/packages/serialbox/package.py
repos/spack_repo/builtin/packages/shamrock/package.py
repos/spack_repo/builtin/packages/sollve/package.py
repos/spack_repo/builtin/packages/sprng/package.py
repos/spack_repo/builtin/packages/sqlite/package.py
repos/spack_repo/builtin/packages/subread/package.py
repos/spack_repo/builtin/packages/tempo/package.py
repos/spack_repo/builtin/packages/tfel/package.py
repos/spack_repo/builtin/packages/timemory/package.py
repos/spack_repo/builtin/packages/turbomole/package.py
repos/spack_repo/builtin/packages/wannier90/package.py
repos/spack_repo/builtin/packages/whizard/package.py
repos/spack_repo/builtin/packages/wrf/package.py
repos/spack_repo/builtin/packages/wt/package.py
repos/spack_repo/builtin/packages/yosys/package.py
repos/spack_repo/builtin/packages/zfp/package.py
repos/spack_repo/builtin/packages/zlib/package.py
tests/repos/spack_repo/builtin_mock/packages/cmake_client/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/py_xhistogram/package.py:30: [E231] missing whitespace after ','
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

wdconinc

Looks good to me.

@spackbot

* fix build with python 3.12 * [@spackbot] updating style on behalf of Chrismarsh * style * increase upper patch version limit * switch to .patch file * style * [@spackbot] updating style on behalf of Chrismarsh --------- Co-authored-by: Chrismarsh <Chrismarsh@users.noreply.github.com>

@spackbot

* fix build with python 3.12 * [@spackbot] updating style on behalf of Chrismarsh * style * increase upper patch version limit * switch to .patch file * style * [@spackbot] updating style on behalf of Chrismarsh --------- Co-authored-by: Chrismarsh <Chrismarsh@users.noreply.github.com>

@spackbot

* fix build with python 3.12 * [@spackbot] updating style on behalf of Chrismarsh * style * increase upper patch version limit * switch to .patch file * style * [@spackbot] updating style on behalf of Chrismarsh --------- Co-authored-by: Chrismarsh <Chrismarsh@users.noreply.github.com>

fix build with python 3.12

1559329

github-actions bot added python dependencies patch update-package labels Jul 31, 2025

[@spackbot] updating style on behalf of Chrismarsh

220b002

Chrismarsh added 2 commits July 31, 2025 18:16

style

a8016ab

Merge branch 'package-fix/py-xhistogram' of github.com:Chrismarsh/spa…

8ff759e

…ck-packages into package-fix/py-xhistogram

wdconinc reviewed Aug 1, 2025

View reviewed changes

repos/spack_repo/builtin/packages/py_xhistogram/package.py Outdated Show resolved Hide resolved

wdconinc self-assigned this Aug 1, 2025

Chrismarsh added 2 commits August 1, 2025 17:45

increase upper patch version limit

0fb5c99

switch to .patch file

2da70b2

Chrismarsh requested a review from wdconinc August 1, 2025 18:06

style

6d3772e

[@spackbot] updating style on behalf of Chrismarsh

e200a8b

wdconinc approved these changes Aug 1, 2025

View reviewed changes

wdconinc merged commit a9d5a31 into spack:develop Aug 1, 2025
17 checks passed

Chrismarsh deleted the package-fix/py-xhistogram branch August 1, 2025 21:12

greenc-FNAL mentioned this pull request Aug 6, 2025

Merge from upstream 2025-08-06 FNALssi/spack-packages#5

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

py-xhistogram: fix python 3.12#898

py-xhistogram: fix python 3.12#898
wdconinc merged 8 commits intospack:developfrom
Chrismarsh:package-fix/py-xhistogram

Chrismarsh commented Jul 31, 2025

Uh oh!

Chrismarsh commented Jul 31, 2025

Uh oh!

spackbot-app bot commented Jul 31, 2025

Uh oh!

spackbot-app bot commented Jul 31, 2025

Uh oh!

Uh oh!

Chrismarsh commented Aug 1, 2025

Uh oh!

spackbot-app bot commented Aug 1, 2025

Uh oh!

spackbot-app bot commented Aug 1, 2025

Uh oh!

wdconinc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Chrismarsh commented Jul 31, 2025

Uh oh!

Chrismarsh commented Jul 31, 2025

Uh oh!

spackbot-app bot commented Jul 31, 2025

Uh oh!

spackbot-app bot commented Jul 31, 2025

Uh oh!

Uh oh!

Chrismarsh commented Aug 1, 2025

Uh oh!

spackbot-app bot commented Aug 1, 2025

Uh oh!

spackbot-app bot commented Aug 1, 2025

Uh oh!

wdconinc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants