Skip to content

openloops: add check for added Fortran compiler#34014

Merged
bernhardkaindl merged 3 commits intospack:developfrom
bernhardkaindl:openloops-needs-fortran
Nov 23, 2022
Merged

openloops: add check for added Fortran compiler#34014
bernhardkaindl merged 3 commits intospack:developfrom
bernhardkaindl:openloops-needs-fortran

Conversation

@bernhardkaindl
Copy link
Copy Markdown
Contributor

Add a check for self.compiler.fc like in openmpi and openblas before using SPACK_FC

@spack spack deleted a comment from spackbot-app bot Nov 19, 2022
@bernhardkaindl bernhardkaindl marked this pull request as ready for review November 20, 2022 00:32
@spack spack deleted a comment from spackbot-app bot Nov 20, 2022
@spack spack deleted a comment from spackbot-app bot Nov 20, 2022
@iarspider
Copy link
Copy Markdown
Contributor

Thanks!

@bernhardkaindl
Copy link
Copy Markdown
Contributor Author

Thanks!

@iarspider: You can enable me to merge it when you click "Add your review" on the right of "Review required", and then select "Approve" in the window after that and then submit the Approve.

You can also open the same Review dialog in the "Files" tab in the right upper corner.

@bernhardkaindl bernhardkaindl enabled auto-merge (squash) November 20, 2022 17:35
iarspider
iarspider previously approved these changes Nov 21, 2022
@iarspider
Copy link
Copy Markdown
Contributor

Thanks!

@iarspider: You can enable me to merge it when you click "Add your review" on the right of "Review required", and then select "Approve" in the window after that and then submit the Approve.

You can also open the same Review dialog in the "Files" tab in the right upper corner.

I can't - I don't have merge access :)

@alalazo alalazo self-assigned this Nov 23, 2022
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
@spack spack deleted a comment from spackbot-app bot Nov 23, 2022
@spack spack deleted a comment from spackbot-app bot Nov 23, 2022
@bernhardkaindl bernhardkaindl merged commit a845b1f into spack:develop Nov 23, 2022
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants