Skip to content

vtk-m: Changed test method names and skipping non-applicable tests to use new API#44705

Merged
tldahlgren merged 4 commits intospack:developfrom
AcriusWinter:vtk-m_old_to_new_test
Jun 18, 2024
Merged

vtk-m: Changed test method names and skipping non-applicable tests to use new API#44705
tldahlgren merged 4 commits intospack:developfrom
AcriusWinter:vtk-m_old_to_new_test

Conversation

@AcriusWinter
Copy link
Copy Markdown
Contributor

@AcriusWinter AcriusWinter commented Jun 13, 2024

Update standalone test API. See below comment for test output.

Supersedes #35807 updates for the package

https://spack.readthedocs.io/en/latest/packaging_guide.html#stand-alone-tests

@spackbot-app spackbot-app bot added stand-alone-tests Stand-alone (or smoke) tests for installed packages update-package labels Jun 13, 2024
@spackbot-app spackbot-app bot requested review from kmorel and vicentebolea June 13, 2024 18:46
@tldahlgren tldahlgren changed the title Changed test method names and skipping non-applicable tests from old to new approach vtk-m: Changed test method names and skipping non-applicable tests from old to new approach Jun 13, 2024
@tldahlgren tldahlgren self-assigned this Jun 13, 2024
@AcriusWinter
Copy link
Copy Markdown
Contributor Author

spack test run vtk-m
==> Spack test 7x3itvd7jreqc4s2kgtokomt7azuwhw2
==> Testing package vtk-m-2.1.0-k4ixr3n
============================== 1 passed of 1 spec ==============================

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed spack install --test=root vtk-m~examples fails to build because the test raises an exception (as expected).

Almost there. A couple of minor changes.

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the test purpose needs to be clearer.

@tldahlgren
Copy link
Copy Markdown
Contributor

spack test run vtk-m ==> Spack test 7x3itvd7jreqc4s2kgtokomt7azuwhw2 ==> Testing package vtk-m-2.1.0-k4ixr3n ============================== 1 passed of 1 spec ==============================

Please paste the test summary so it shows the parts.

@AcriusWinter
Copy link
Copy Markdown
Contributor Author

========================= SUMMARY: vtk-m-2.1.0-k4ixr3n =========================
VtkM::test_smoke_test .. PASSED
============================= 1 passed of 1 parts ==============================

@tldahlgren tldahlgren enabled auto-merge (squash) June 15, 2024 00:01
@tldahlgren tldahlgren disabled auto-merge June 15, 2024 00:56
@tldahlgren tldahlgren enabled auto-merge (squash) June 15, 2024 00:56
@tldahlgren
Copy link
Copy Markdown
Contributor

Looks like CI succeeded (per contents of the link) but is being reported as failed.

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 18, 2024

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'error': 'invalid_token', 'error_description': 'Token is expired. You can either do re-authorization or token refresh.'}

@tldahlgren
Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 18, 2024

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'error': 'invalid_token', 'error_description': 'Token is expired. You can either do re-authorization or token refresh.'}

@tldahlgren
Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 18, 2024

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'error': 'invalid_token', 'error_description': 'Token is expired. You can either do re-authorization or token refresh.'}

@tldahlgren
Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 18, 2024

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'error': 'invalid_token', 'error_description': 'Token is expired. You can either do re-authorization or token refresh.'}

@mvandenburgh
Copy link
Copy Markdown
Member

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 18, 2024

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'error': 'invalid_token', 'error_description': 'Token is expired. You can either do re-authorization or token refresh.'}

@mvandenburgh
Copy link
Copy Markdown
Member

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 18, 2024

I've started that pipeline for you!

@tldahlgren tldahlgren merged commit e6ae42b into spack:develop Jun 18, 2024
mpokorny pushed a commit to mpokorny/spack that referenced this pull request Jun 20, 2024
…om old to new approach (spack#44705)

* vtk-m: Changed test method names and skipping non-applicable tests from old to new approach

-----
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren tldahlgren changed the title vtk-m: Changed test method names and skipping non-applicable tests from old to new approach vtk-m: Changed test method names and skipping non-applicable tests to use new API Jun 20, 2024
hariharan-devarajan pushed a commit to hariharan-devarajan/spack that referenced this pull request Jul 10, 2024
…om old to new approach (spack#44705)

* vtk-m: Changed test method names and skipping non-applicable tests from old to new approach

-----
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Aug 3, 2024
…om old to new approach (spack#44705)

* vtk-m: Changed test method names and skipping non-applicable tests from old to new approach

-----
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
FrederickDeny pushed a commit to FrederickDeny/spack that referenced this pull request Aug 26, 2024
…om old to new approach (spack#44705)

* vtk-m: Changed test method names and skipping non-applicable tests from old to new approach

-----
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stand-alone-tests Stand-alone (or smoke) tests for installed packages update-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants