Skip to content

VTK: fix build with Apple Clang 16#46463

Closed
adamjstewart wants to merge 1 commit intospack:developfrom
adamjstewart:packages/vtk
Closed

VTK: fix build with Apple Clang 16#46463
adamjstewart wants to merge 1 commit intospack:developfrom
adamjstewart:packages/vtk

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart commented Sep 18, 2024

Without this flag, I see:

ld: warning: duplicate -rpath '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/cgns-4.4.0-hyx7mtf6mxo7h7gz5rx4lthyrypp4u7h/lib' ignored
ld: warning: duplicate -rpath '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/hdf5-1.14.3-emur2bgnslki3qnnmeqoo5ehaeyeseq5/lib' ignored
ld: duplicate LC_RPATH '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/hdf5-1.14.3-emur2bgnslki3qnnmeqoo5ehaeyeseq5/lib' in '/Users/Adam/spack/opt/spack/darwin-sequoia-m2/apple-clang-16.0.0/cgns-4.4.0-hyx7mtf6mxo7h7gz5rx4lthyrypp4u7h/lib/libcgns.4.4.dylib'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

johnwparent
johnwparent approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnwparent johnwparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Might be able to handle this from the VTK side, but no need to hold off this PR on that.

@johnwparent
Copy link
Copy Markdown
Contributor

johnwparent commented Sep 20, 2024

@spackbot run pipeline

@adamjstewart adamjstewart mentioned this pull request Sep 20, 2024
Closed
3 tasks
@adamjstewart
Copy link
Copy Markdown
Member Author

adamjstewart commented Sep 20, 2024

@spackbot run pipeline

@adamjstewart
Copy link
Copy Markdown
Member Author

adamjstewart commented Sep 23, 2024

Superseded by #46536. This may be a bug in Spack's compiler wrappers, or it may be a bug in the CGNS/HDF5/VTK build systems. I'm not sure where the duplicate flag is coming from.

@adamjstewart adamjstewart deleted the packages/vtk branch September 23, 2024 13:55
@adamjstewart adamjstewart restored the packages/vtk branch October 3, 2024 10:10
@adamjstewart
Copy link
Copy Markdown
Member Author

adamjstewart commented Oct 3, 2024

Superseding PR was closed

@adamjstewart adamjstewart reopened this Oct 3, 2024
@adamjstewart
Copy link
Copy Markdown
Member Author

adamjstewart commented Oct 5, 2024

I can no longer reproduce the issues I was seeing

@adamjstewart adamjstewart deleted the packages/vtk branch October 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnwparent johnwparent johnwparent approved these changes

@chuckatkins chuckatkins Awaiting requested review from chuckatkins

@danlipsa danlipsa Awaiting requested review from danlipsa

@tgamblin tgamblin Awaiting requested review from tgamblin

@haampie haampie Awaiting requested review from haampie

Assignees

No one assigned

Labels

update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamjstewart @johnwparent