Skip to content

Conversation

@wdconinc
Copy link
Contributor

This PR fixes up #47529 which forgot to add MesonPackage.

@spackbot-app
Copy link

spackbot-app bot commented Nov 14, 2024

Hi @wdconinc! I noticed that the following package(s) don't yet have maintainers:

  • pixman

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("wdconinc")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame pixman

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@haampie
Copy link
Member

haampie commented Nov 15, 2024

It also forgets to import spack.build_systems.{autotools,meson}

@wdconinc
Copy link
Contributor Author

It also forgets to import spack.build_systems.{autotools,meson}

Many packages do not import this. I am not sure if we can insist on this broadly without an audit or mypy check that points this out.

@haampie
Copy link
Member

haampie commented Nov 16, 2024

Many packages do not import this. I am not sure if we can insist on this broadly without an audit or mypy check that points this out.

Feel free to merge #47619 ;)

@wdconinc
Copy link
Contributor Author

It also forgets to import spack.build_systems.{autotools,meson}

Deferred to #47617.

@haampie haampie merged commit fe2bf4c into develop Nov 17, 2024
13 checks passed
@haampie haampie deleted the packages/pixman-meson branch November 17, 2024 08:03
fryeguy52 pushed a commit to fryeguy52/spack that referenced this pull request Dec 17, 2024
kshea21 pushed a commit to kshea21/spack that referenced this pull request Dec 26, 2024
nkoukpaizan pushed a commit to nkoukpaizan/spack that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants