Fixes Photon monolithic builds on 0.7.0-rc.3#1370
Merged
m-mcgowan merged 1 commit intorelease/v0.7.0-rc.4from Nov 6, 2017
Merged
Fixes Photon monolithic builds on 0.7.0-rc.3#1370m-mcgowan merged 1 commit intorelease/v0.7.0-rc.4from
m-mcgowan merged 1 commit intorelease/v0.7.0-rc.4from
Conversation
technobly
approved these changes
Aug 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #1368
link_heap_locationandlink_heap_location_enddefinitions missing in linker file.Solution
Cherry-pick a71eba6 from #1369
Steps to Test
Monolithic build should now succeed.
Example App
N/A
References
Closes #1368
Completeness
Bug fix
[PR #1370][Fixes #1368][Photon/P1]Fixes Photon/P1 monolithic builds (MODULAR=n) introduced in 0.7.0-rc.2.