Name addressable gem as runtime dep #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward-port of v1.5.7 This dependency is already required and has been referenced in code for some time. Because Webmock requires Addressable and webmock is used in the test suite, this runtime dependency wasn't surfaced by the in-project test suite. This change simply names that gem as a runtime requirement so bundler can appropriately include it if nothing else happens to. Other changes: - drop ruby 2.5 and 2.6 from the test suite matrix - fix unrelated test breakage in spec Not entirely sure what's going on here, but since this fixes the failure I'm banking on a deep comparison mismatch when the hash gets recreated. Only creating one hash works around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of v1.5.7
This dependency is already required and has been referenced in code for some time. Because Webmock requires Addressable and webmock is used in the test suite, this runtime dependency wasn't surfaced by the in-project test suite.
This change simply names that gem as a runtime requirement so bundler can appropriately include it if nothing else happens to.
Other changes: