You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merged release and binary upload into a single workflow job
Removed separate release.yml workflow file
Added debug step and conditional GoReleaser execution after release-please
Added include-component-in-tag: false to release-please config
Diagram Walkthrough
flowchart LR
A["Push to main"] --> B["release-please-action"]
B -- "release_created=true" --> C["Checkout code"]
C --> D["Set up Go"]
D --> E["Fetch tags"]
E --> F["GoReleaser (build & upload binaries)"]
B -- "release_created=false" --> G["Skip binary upload"]
Loading
File Walkthrough
Relevant files
Enhancement
release-please.yml
Merge GoReleaser steps into release-please workflow
.github/workflows/release-please.yml
Added issues: write permission
Added debug step to print release outputs
Added conditional steps for checkout, Go setup, tag fetch, and GoReleaser execution after release is created
Consolidated binary upload into the same job as release-please
The workflow references actions/checkout@v6 and actions/setup-go@v6, but the latest stable versions are v4 and v5 respectively. Using non-existent versions will cause the workflow to fail. Similarly, go-version: '1.25.6' does not exist (latest Go is around 1.22.x); this will cause the Go setup step to fail.
uses: actions/checkout@v6with:
fetch-depth: 0
- name: Set up Goif: ${{ steps.release.outputs.release_created }}uses: actions/setup-go@v6with:
go-version: '1.25.6'cache: true
The debug step prints release outputs (tag_name, version, release_created) to the workflow logs. While these are not secrets, care should be taken that no sensitive outputs are inadvertently logged. More importantly, verify this debug step should not be removed before merging to production, as it may expose internal release metadata publicly in the workflow logs.
The debug step runs unconditionally on every push to main, even when no release is created. This adds unnecessary noise to workflow logs. Add the same condition used by other steps to only run this when a release is created.
Why: The debug step runs unconditionally on every push to main, adding noise to logs when no release is created. Adding if: ${{ steps.release.outputs.release_created }} would make it consistent with other steps, though this is a minor quality improvement.
Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Bug fix
Description
Merged release and binary upload into a single workflow job
Removed separate
release.ymlworkflow fileAdded debug step and conditional GoReleaser execution after release-please
Added
include-component-in-tag: falseto release-please configDiagram Walkthrough
File Walkthrough
release-please.yml
Merge GoReleaser steps into release-please workflow.github/workflows/release-please.yml
issues: writepermissionGoReleaser execution after release is created
release.yml
Remove standalone release workflow file.github/workflows/release.yml
release-please.ymlrelease-please-config.json
Exclude component name from release tagsrelease-please-config.json
include-component-in-tag: falseto prevent component name frombeing included in the release tag