Skip to content

Conversation

@Monska85
Copy link
Contributor

@Monska85 Monska85 commented May 29, 2025

PR Type

Bug fix


Description

• Change IAM binding to member for workload identity
• Fix conflicts with multiple role bindings
• Update documentation and changelog
• Prevent permission management issues


Changes walkthrough 📝

Relevant files
Bug fix
main.tf
Replace IAM binding with member resource                                 

main.tf

• Replace google_service_account_iam_binding with
google_service_account_iam_member
• Change members array to single
member parameter
• Simplify IAM role assignment structure

+2/-5     
Documentation
CHANGELOG.md
Add changelog entry for IAM fix                                                   

CHANGELOG.md

• Add version 0.3.1 entry with release date
• Document IAM binding to
member change
• Explain rationale for avoiding multiple binding
conflicts

+8/-0     
README.md
Update resource documentation reference                                   

README.md

• Update resource reference from google_service_account_iam_binding to
google_service_account_iam_member

+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • …oid issues with permission granted from other sources
    @sparkfabrik-ai-bot
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Resource Migration

    The change from google_service_account_iam_binding to google_service_account_iam_member is a breaking change that will cause Terraform to destroy and recreate the IAM permission. This could cause temporary loss of access during deployment. Consider using terraform state mv or import blocks to handle the migration gracefully.

    resource "google_service_account_iam_member" "this" {
      service_account_id = local.sa_name
      role               = "roles/iam.workloadIdentityUser"
      member             = local.principal_set
    }

    @sparkfabrik-ai-bot
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Monska85 Monska85 merged commit 8312ac9 into main May 29, 2025
    1 check passed
    @Monska85 Monska85 deleted the fix/change_binding_to_member branch May 29, 2025 12:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants