Skip to content

Conversation

@edspark
Copy link
Contributor

@edspark edspark commented Sep 26, 2025

Adds a 2x03 2mm SMD Connector and a recessed SMD RJ45 Ethernet Jack

@edspark
Copy link
Contributor Author

edspark commented Sep 26, 2025

It looks like I branched this off of another pull request (apologies) let me know if that causes issues. I can save locally and re-create a new pull request if needed.

@nseidle
Copy link
Member

nseidle commented Sep 26, 2025

Generally it looks ok for review. But because it's conflicting with main, I won't be able to resolve it. If possible. please close and resubmit a PR that doesn't have the conflicts.

@edspark
Copy link
Contributor Author

edspark commented Sep 26, 2025

This pull request has been fixed. Please note that I could not find the 3d model for the Recessed Ethernet Jack that you had previously discovered. I forgot to save the 3d models locally when I reset the branch.

@nseidle
Copy link
Member

nseidle commented Sep 26, 2025

Nice! Thanks for fixing conflicts. Here are the changes I made. Please pull main after merge and review in your design. Sorry, some of these are breaking changes!

  • I changed the datasheet link to one that shows FP with peg hole dims. I see 1.1 and 1.2mm peg holes on the 2x03 2mm header. So your 1.17mm looks good.
image image
  • We're getting more stringent with our naming conventions. Connector names now have pitch, header/socket, vertical/horz, SMD/PTH, _Peg variants.
image
  • Renamed RJ45 to Mid Mount to follow Digikey naming conventions. Added model and a bit of silk to FP. The model isn't 100% (not long enough) but it's close.
image
  • The cutout lines being on the B.Fab layer have me a bit worried. I assume you mimic these in Edge.cuts on your layout? Why not use F.Fab?
image
  • Give your FPs more buffer space on the courtyards. This tight will lead to part collisions, especially on such a large component:
image image
  • FPs don't get PROD_IDs. That goes on the symbol (one FP could be used with multiple symbols).
image
  • Please ask me to show you how to colorize 3D models. If it's a STP file, it's likely not going to render correctly.
image image
  • The 75 Ohm resistor symbol looks odd. Honestly, I just duplicate the symbol of a resistor nearest on the list, change the PROD_ID and value, FP if needed, and call it a day.
image image

@nseidle nseidle merged commit 2092d81 into main Sep 26, 2025
@nseidle nseidle mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants