Skip to content

Conversation

@mjs513
Copy link

@mjs513 mjs513 commented Sep 12, 2017

Added ability to select wire bus in setup.

  1. mySensor.begin() defaults to Wire
  2. mySensor.begin(&Wire1) sets I2C to use Wire1
  3. mySensor.begin(&Wire2) sets I2C to use Wire2

Also incorporated Pull Request 8.

Hope this helps someone.
Mike

@nseidle
Copy link
Member

nseidle commented Mar 9, 2018

I like this feature a lot. I think all libraries should have the Wire stream passed to it as an option. However, your PR seems to include a lot of other small changes that have me worried. Why did you change this line (variable declare of dig_H6)?

@nseidle
Copy link
Member

nseidle commented Mar 9, 2018

I see why you changed H6 - explained in a previous PR. There's still a lot of changes that are not Wire stream related in your PR. Can you either submit a new one or help me understand your other changes?

@mjs513
Copy link
Author

mjs513 commented Mar 10, 2018

Hi Nathan
Sorry for the delay in responding - had to go look at what I changed, its been awhile since I looked at it :). Anyway in going back over the changes anything not stream related came from the PR#8. Just had to do a sanity check before I responded. There should be no other changes.

The line you referenced comes directly from PR#8 which I see you merged already.

Mike

@nseidle
Copy link
Member

nseidle commented Mar 23, 2018

Hi Mike - Thanks for this PR. I have implemented the core of your idea but rolled it into a larger overhaul of the library. We should have a v2.0 of the lib available soon with examples showing how to use other Wire ports.

@nseidle nseidle closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants