Fix compile issue for Teensy 3.2 boards. #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ever defined. Commenting out the elif for Teensy boards fixes this issue, but I am not sure if a buffer length of 32 is correct.
|
Yup. It's a problem. Thanks for the PR but I'll push a slightly different fix. I'd rather define the buffer size under the Teensy gate than have it default. For now I'm setting it to 32 bytes but with i2c_t3 these buffers could be increased significantly. New INOs should be pushed shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firmware did not work with Teensy 3.2 because I2C_BUFFER_LENGTH was never defined. Commenting out the elif for Teensy boards fixes this issue, but I am not sure if a buffer length of 32 is correct.