Use a high speed parser to validate and process the NMEA, RTCM and UBX messages #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add debug menu items to print: * Battery messages * Rover Accuracy messages * Messages with bad checksums or CRCs * Log file messages * Ring buffer offsets * NTRIP server messages (already in debug menu) * NTRIP client messages * States of the main state machine * Duplicate states of the main state machine
Breakup the RTCM parser in NtripServer.ino into a bunch of functions using the function address as the state value. This eliminates decision overhead (switch) within the RTCM parser for each character. Use a callback routine to handle the end of message processing
Replace SFE_UBLOX_GNSS::processRTCM in Base.ino with SFE_UBLOX_GNSS::processRTCMframe in NtripServer.ino. This removes one level of routine that is called with a single character. Remove the intermediate routine ntripServerProcessRTCM, move the end conditions into the parser routine ntripServerRtcmReadCrc. Don't write the WiFi data a byte at a time, instead attempt to write the entire message at once. Also handle the flow control return value from the WiFi routine.
nseidle
added a commit
that referenced
this pull request
Dec 22, 2022
This is the integration of PR #261.
|
This has been integrated into the release candidate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made up of several commits:
This commit requires (is layered on top of):
#250 - Enable printing of WiFi IP address by default
#251 - Validate the RTCM length field
#252 - Add printTimeStamp to support.ino
#254 - Add debug menu items to print messages
#255 - Enable/disable printing of battery status messages, requires #254
#256 - Enable/disable printing of the Rover Accuracy messages, requires #254
#259 - Enable/disable printing of states and duplicate states, requires #254
#260 - Enable/disable printing of log file status messages, requires #254