This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Update library helper links and correct all instances of "Ublox" #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for helping fix my Ublox correction quest! I get upset when people spell SparkFun Sparkfun, so I wanted to give the same respect to u-blox. This helps. I want to shift SparkFun towards proper GNSS terminology so Adam, if I may ask you to, please change to |
Contributor
Author
|
@nseidle I was thinking the exact same thing as I was making the changes, but I wasn't sure if changing all instances of "GPS" to "GNSS" was a rock we wanted to turn over. I agree that as a community, we should endeavour to use proper terminology! |
Collaborator
|
This is great Adam (@adamgarbo ) - sincere thanks! |
PaulZC
approved these changes
Dec 30, 2020
Collaborator
PaulZC
left a comment
PaulZC
left a comment
There was a problem hiding this comment.
Looking good - thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @PaulZC,
This PR for the v2.0 candidate includes a couple of minor changes:
I've replaced all instances of the
//http://librarymanager/All#SparkFun_Ublox_GPShelper link with//http://librarymanager/All#SparkFun_u-blox_GPSAs part of our constant efforts to please the OCD gods (@nseidle may appreciate this), I've attempted to replace all instances of "Ublox" with "u-blox" contained in comments and/or print commands for the entire library.
I also manually reviewed all the changes to ensure I hadn't accidentally changed any instances of "Ublox" that were actually operational code.
Cheers,
Adam